mgr/mgr_module : Fix keyerror for op if rule steps first element is opcode #36947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
batrick
requested changes
Sep 2, 2020
There was a problem hiding this comment.
Please fix the formatting for your commit message in 4048dd9:
mgr/mgr_module: fix keyerror for op
If rule steps first element is opcode.
Fixes: https://tracker.ceph.com/issues/47272
In particular, the whitespace around the colons.
|
Thanks @batrick. Let me correct it. |
|
The more simpler way would be :
|
pdvian
force-pushed
the
wip-mgr-get-rule-root
branch
from
4048dd9
to
ee83a17
Compare
|
|
tchaikov
reviewed
Sep 3, 2020
If rule steps first element is opcode. Fixes: https://tracker.ceph.com/issues/47272 Signed-off-by: Prashant Dhange <pdhange@redhat.com>
pdvian
force-pushed
the
wip-mgr-get-rule-root
branch
from
ee83a17
to
48a345c
Compare
batrick
approved these changes
Sep 4, 2020
|
jenkins test api |
failures tracked by
and i tested locally using ../qa/run-standalone.sh osd-backfill-prio.shit passed. |
tchaikov
approved these changes
Sep 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes : https://tracker.ceph.com/issues/47272
Signed-off-by: Prashant Dhange pdhange@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox