octopus: mds: add request to batch_op before taking auth pins and locks #37022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
batch_op is in either CInode::batch_ops or CDentry::batch_ops. Current code gets the map by dereferencing mdr->in[0] or mdr->dn[0].back(). The problem is that MDCache::path_traverse() may clear mdr->in[0] and mdr->dn[0]. batch_op leaks when mds kills a request whose mdr->in[0] or mdr->dn[0] were cleared. Signed-off-by: "Yan, Zheng" <zyan@redhat.com> (cherry picked from commit 7768d2c) Conflicts: src/mds/Mutation.h - octopus does not use the specific ns, use the original one
Signed-off-by: "Yan, Zheng" <zyan@redhat.com> (cherry picked from commit 7e59369)
MDS does not dispatch non-head requests in batch_op. So non-head requests in batch_op should not hold any authpins and locks. Otherwise head request may wait for these authpins/locks. Fixes: https://tracker.ceph.com/issues/44785 Signed-off-by: "Yan, Zheng" <zyan@redhat.com> (cherry picked from commit 975d9ba)
batrick
approved these changes
Oct 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/46524
backport of #34246
parent tracker: https://tracker.ceph.com/issues/44785
this backport was staged using ceph-backport.sh version 15.1.1.389
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh