Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mds: fix purge_queue's _calculate_ops is inaccurate #37037

Merged
merged 1 commit into from Sep 19, 2020

Conversation

gmayyyha
Copy link
Contributor

@gmayyyha gmayyyha commented Sep 8, 2020

No need to account for removing (or zeroing) backtrace,
because if item.size is 0, num is already set to 1.

Fixes: https://tracker.ceph.com/issues/47353
Signed-off-by: Yanhu Cao gmayyyha@gmail.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@varshar16 varshar16 added cephfs Ceph File System needs-review labels Sep 8, 2020
@varshar16 varshar16 requested a review from a team September 8, 2020 08:14
@gmayyyha gmayyyha force-pushed the wip-47353 branch 3 times, most recently from bdaef0b to ca495ee Compare September 9, 2020 04:03
@gmayyyha
Copy link
Contributor Author

jenkins test api

Copy link
Member

@batrick batrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

src/mds/PurgeQueue.cc Show resolved Hide resolved
No need to account for removing (or zeroing) backtrace,
because if item.size is 0, num is already set to 1.

Fixes: https://tracker.ceph.com/issues/47353
Signed-off-by: Yanhu Cao <gmayyyha@gmail.com>
@batrick
Copy link
Member

batrick commented Sep 19, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants