octopus: compressor: Add a config option to specify Zstd compression level #37118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new configuration item called 'compressor_zstd_level' so that the Zstandard compression level can be tuned to the workload on a cluster. Fixes: https://tracker.ceph.com/issues/47422 Signed-off-by: Bryan Stillwell <bstillwell@godaddy.com>
The default compression level of 5 for Zstandard is too high for the majority of use cases since it requires too many CPU cycles. This patch switches the default to 1. Signed-off-by: Bryan Stillwell <bstillwell@godaddy.com>
bstillwell
deleted the
add_conf_option_zstd_compression_level-octopus
branch
bstillwell
restored the
add_conf_option_zstd_compression_level-octopus
branch
smithfarm
suggested changes
Sep 18, 2020
There was a problem hiding this comment.
Please re-do with git cherry-pick -x and following the other cherry-picking rules set out in this document:
https://github.com/ceph/ceph/blob/master/SubmittingPatches-backports.rst
(Also please note that there is a backporting script which streamlines the backporting process. This is described in the same document.)
smithfarm
changed the title
bstillwell
deleted the
add_conf_option_zstd_compression_level-octopus
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tracker.ceph.com/issues/47424