nautilus: rgw: ordered bucket listing code clean-up #37169
Conversation
… keys" This reverts commit 04b15ce. While this did fix https://tracker.ceph.com/issues/40905, it did so in an unnecessarily complex manner. So we're reverting it to more easily apply a cleaner solution. Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
The code mistakenly uses the current marker to figure out how to skip past a pseudo-directory. This could allow for some entries in a bucket to be skipped. The code should have used the current pseudo-directory to determine what to skip past. Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
|
jenkins test make check |
smithfarm
added
nautilus-batch-1
|
@ivancich It would be nice if the commit message could include some (even very brief) verbiage explaining why the fix is applicable only to nautilus and cannot be backported from master or octopus. |
|
@smithfarm I just want to make certain you want that documentation in the two commit messages. Normally I don't reference specific releases in commit messages. I will update the PR message. |
The PR message is for now, but the commit messages are for posterity. So, yes, I do mean to put the explanation in the commit messages themselves. According to https://github.com/ceph/ceph/blob/master/SubmittingPatches-backports.rst#cherry-picking-rules one of the cherry-picking rules is: "if a commit could not be cherry-picked from master, the commit message must explain why that was not possible." (emphasis added) So, you would not necessarily have to mention a specific branch (other than "master"). My recommended formulation is "This commit cannot be cherry-picked from master because . . ." This case is discussed further in https://github.com/ceph/ceph/blob/master/SubmittingPatches-backports.rst#notes-on-the-cherry-picking-rules if you're interested. |
smithfarm
changed the title
rgw: ordered bucket listing code clean-up
As a result of an earlier bug-fix, the code for ordered bucket listing is now more complex than it needs to be. This reverts that fix and applies a cleaner one.
This change is not applicable to octopus or later because the ordered bucket listing code underwent a significant change in between. Specifically much of the delimiter filtering logic was moved to cls/osd code.
Fixes: https://tracker.ceph.com/issues/47487
Signed-off-by: J. Eric Ivancich ivancich@redhat.com