nautilus: mon: mark pgtemp messages as no_reply more consistenly in preprocess_… #37171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_pgtemp If a message is forwarded, it's conceivable the leader's and peon's evaluation will disagree about whether the message is useful or not, which could result in the leader ignoring it and the peon having a dangling forwarded message. Fix this by marking the op as no_reply whenever ignoring it. Fixes: https://tracker.ceph.com/issues/46914 Signed-off-by: Greg Farnum <gfarnum@redhat.com> (cherry picked from commit 73a014f)
yuriw
approved these changes
Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/47092
backport of #36593
parent tracker: https://tracker.ceph.com/issues/46914
this backport was staged using ceph-backport.sh version 15.1.1.389
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh