Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nautilus: compressor: Add a config option to specity Zstd compression level #37219

Conversation

bstillwell
Copy link

@bstillwell bstillwell commented Sep 17, 2020

Add a new configuration item called 'compressor_zstd_level' so that the
Zstandard compression level can be tuned to the workload on a cluster.

Fixes: https://tracker.ceph.com/issues/47425
Signed-off-by: Bryan Stillwell <bstillwell@godaddy.com>
The default compression level of 5 for Zstandard is too high for the majority
of use cases since it requires too many CPU cycles.  This patch switches the
default to 1.

Signed-off-by: Bryan Stillwell <bstillwell@godaddy.com>
@bstillwell bstillwell force-pushed the add_conf_option_zstd_compression_level-nautilus branch from 2fa67e8 to 0ca51d3 Compare September 17, 2020 22:56
@bstillwell bstillwell changed the title Add conf option zstd compression level (Nautilus) compressor: Add a config option to specity Zstd compression level (Nautilus) Sep 17, 2020
@tchaikov
Copy link
Contributor

@bstillwell you need to cherry-pick the changes using git cherry-pick -x. to connect the cherry-picked changes with the backport commits. if you have a bunch of changes to backport, i'd suggest read https://github.com/ceph/ceph/blob/master/SubmittingPatches-backports.rst

@tchaikov tchaikov added this to the nautilus milestone Sep 18, 2020
@tchaikov tchaikov changed the title compressor: Add a config option to specity Zstd compression level (Nautilus) nautilus: compressor: Add a config option to specity Zstd compression level Sep 18, 2020
Copy link
Contributor

@smithfarm smithfarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please re-do with git cherry-pick -x and following the other cherry-picking rules set out in this document:

https://github.com/ceph/ceph/blob/master/SubmittingPatches-backports.rst

(Also please note that there is a backporting script which streamlines the backporting process. This is described in the same document.)

@bstillwell bstillwell closed this Sep 18, 2020
@bstillwell bstillwell deleted the add_conf_option_zstd_compression_level-nautilus branch September 18, 2020 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants