Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nautilus: mgr/dashboard: Fix many-to-many issue in host-details Grafana dashboard #37306

Merged
merged 1 commit into from Sep 28, 2020
Merged

nautilus: mgr/dashboard: Fix many-to-many issue in host-details Grafana dashboard #37306

merged 1 commit into from Sep 28, 2020

Conversation

p-se
Copy link
Contributor

@p-se p-se commented Sep 22, 2020

backport tracker: https://tracker.ceph.com/issues/47546

backport of #37023
parent tracker: https://tracker.ceph.com/issues/47334

this backport was staged using ceph-backport.sh version 15.1.1.389
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh

@p-se
mgr/dashboard: Fix many-to-many issue in host-details dashboard
444d9d7 
The labels on one side do not match the labels of the other side, where
a label_replace is used. The fix uses the same label_replace on the
missing side.

Fixes: https://tracker.ceph.com/issues/47334

Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
(cherry picked from commit fe64b9d)
@p-se p-se added this to the nautilus milestone Sep 22, 2020
@callithea callithea added the skip-teuthology For PRs whose changes do not have an effect on QA runs/changes are not being tested in Teuthology label Sep 22, 2020
@callithea
Copy link
Member

jenkins test make check

callithea
callithea approved these changes Sep 22, 2020
View reviewed changes
Copy link
Member

@callithea callithea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@p-se
Copy link
Contributor Author

p-se commented Sep 25, 2020

Just adds a label_replace on the left side of the PromQL expression.

@callithea callithea merged commit 2bf2ca9 into ceph:nautilus Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan--f jan--f jan--f approved these changes

@callithea callithea callithea approved these changes

@epuertat epuertat epuertat approved these changes

@alfonsomthd alfonsomthd Awaiting requested review from alfonsomthd

@bk201 bk201 Awaiting requested review from bk201

@LenzGr LenzGr Awaiting requested review from LenzGr

@trociny trociny Awaiting requested review from trociny

@jschmid1 jschmid1 Awaiting requested review from jschmid1

Assignees
No one assigned
Labels
bug-fix dashboard monitoring skip-teuthology For PRs whose changes do not have an effect on QA runs/changes are not being tested in Teuthology
Projects
None yet
Milestone
nautilus
4 participants
@p-se @callithea @jan--f @epuertat