Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nautilus: mgr/dashboard: table detail rows overflow #37324

Merged
merged 1 commit into from Sep 24, 2020

Conversation

aaSharma14
Copy link
Contributor

backport tracker: https://tracker.ceph.com/issues/47570


backport of #37183
parent tracker: https://tracker.ceph.com/issues/47434

this backport was staged using ceph-backport.sh version 15.1.1.389
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh

@aaSharma14
Copy link
Contributor Author

jenkins test api

Copy link
Member

@epuertat epuertat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@smithfarm smithfarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing this backport, @aaSharma14 ! It looks like this might be one of your first contributions.

In order to keep things running smoothly, over the years we have developed some rules that must be followed for backport PRs to be considered. These are listed here:

https://github.com/ceph/ceph/blob/master/SubmittingPatches-backports.rst#cherry-picking-rules

So, backports should be done using git cherry-pick -x from master, not by merging.

@smithfarm
Copy link
Contributor

You can fix this PR by running the following commands (replace ceph with the name of your upstream ceph remote):

git fetch ceph
git reset --hard ceph/nautilus
git cherry-pick -x 7196e03449d585a6b7e1e4065120a571fe2ab894

Then force-push (git push --force ...) to update the PR.

@smithfarm smithfarm changed the title nautilus: mgr/dashboard: table detail rows overflow [DNM PENDING CHERRY-PICK -X] nautilus: mgr/dashboard: table detail rows overflow Sep 23, 2020
@smithfarm smithfarm added the DNM label Sep 23, 2020
Added word-wrap to the rgw-bucket-details table rows to fix overflow of values

Fixes:https://tracker.ceph.com/issues/47434
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
(cherry picked from commit 7196e03)
@aaSharma14
Copy link
Contributor Author

Thanks for contributing this backport, @aaSharma14 ! It looks like this might be one of your first contributions.

In order to keep things running smoothly, over the years we have developed some rules that must be followed for backport PRs to be considered. These are listed here:

https://github.com/ceph/ceph/blob/master/SubmittingPatches-backports.rst#cherry-picking-rules

So, backports should be done using git cherry-pick -x from master, not by merging.

Thanks @smithfarm , yes this was indeed my first backport, I have redone it according to your suggestions.

@smithfarm smithfarm changed the title [DNM PENDING CHERRY-PICK -X] nautilus: mgr/dashboard: table detail rows overflow nautilus: mgr/dashboard: table detail rows overflow Sep 23, 2020
@smithfarm smithfarm added nautilus-batch-1 nautilus point releases needs-qa and removed DNM labels Sep 23, 2020
@smithfarm smithfarm requested a review from a team September 23, 2020 12:51
@yuriw
Copy link
Contributor

yuriw commented Sep 23, 2020

@smithfarm smithfarm removed their request for review September 23, 2020 19:31
@yuriw yuriw merged commit 4d1f414 into ceph:nautilus Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants