mgr/dashboard: Add clay plugin support #37440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LenzGr
reviewed
Sep 29, 2020
LenzGr
reviewed
Sep 29, 2020
...d/src/app/ceph/pool/erasure-code-profile-form/erasure-code-profile-form-modal.component.html
Outdated
Show resolved
Hide resolved
LenzGr
reviewed
Sep 29, 2020
...end/src/app/ceph/pool/erasure-code-profile-form/erasure-code-profile-form-modal.component.ts
Outdated
Show resolved
Hide resolved
LenzGr
reviewed
Sep 29, 2020
src/pybind/mgr/dashboard/frontend/src/app/shared/api/erasure-code-profile.service.ts
Outdated
Show resolved
Hide resolved
The erasure code plugin "clay" is now supported by the dashboard. Now a clay based profile can be created in the ec profile creation modal dialog which can be found in the pool form. The defaults of the plugin are calculated or preselected and shown in the dashboard, therefore things are made mandatory even if they are not on the cli, but as they automatically set the user doesn't have to set them, but sees the defaults instantly before creating the profile. (This is the same behavior that is used for all other supported plugins.) Fixes: https://tracker.ceph.com/issues/44433 Signed-off-by: Stephan Müller <smueller@suse.com>
|
Addressed all comments |
|
jenkins test api |
|
jenkins test docs |
tspmelo
approved these changes
Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The erasure code plugin "clay" is now supported by the dashboard. Now a
clay based profile can be created in the ec profile creation modal
dialog which can be found in the pool form.
The defaults of the plugin are calculated or preselected and shown in the
dashboard, therefore things are made mandatory even if they are not on the
cli, but as they automatically set the user doesn't have to set them,
but sees the defaults instantly before creating the profile.
(This is the same behavior that is used for all other supported
plugins.)
Fixes: https://tracker.ceph.com/issues/44433
Signed-off-by: Stephan Müller smueller@suse.com
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox