Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

octopus: mgr/dashboard: get rgw daemon zonegroup name from mgr #37620

Merged
merged 1 commit into from Nov 6, 2020
Merged

octopus: mgr/dashboard: get rgw daemon zonegroup name from mgr #37620

merged 1 commit into from Nov 6, 2020

Conversation

alfonsomthd
Copy link
Contributor

backport tracker: https://tracker.ceph.com/issues/47811

backport of #37449
parent tracker: https://tracker.ceph.com/issues/47676

this backport was staged using ceph-backport.sh version 15.1.1.389
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh

@alfonsomthd
mgr/dashboard: get rgw daemon zonegroup name from mgr
ef8a35b 
Fixes: https://tracker.ceph.com/issues/47676
Signed-off-by: Alfonso Martinez <almartin@redhat.com>
(cherry picked from commit cdeaea2)

 Conflicts:
	src/pybind/mgr/dashboard/services/rgw_client.py
        - Resolved conflicts.
@alfonsomthd alfonsomthd requested a review from a team as a code owner October 9, 2020 17:09
@alfonsomthd alfonsomthd added this to the octopus milestone Oct 9, 2020
@alfonsomthd alfonsomthd requested a review from bk201 October 9, 2020 17:30
@alfonsomthd alfonsomthd requested a review from a team October 14, 2020 08:48
@callithea
Copy link
Member

callithea commented Oct 22, 2020 •
edited

callithea
callithea approved these changes Oct 23, 2020
View reviewed changes
Copy link
Member

@callithea callithea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

s0nea
s0nea approved these changes Oct 26, 2020
View reviewed changes
Copy link
Member

@s0nea s0nea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

epuertat
epuertat approved these changes Nov 5, 2020
View reviewed changes
Copy link
Member

@epuertat epuertat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@callithea callithea merged commit 27a1d7d into ceph:octopus Nov 6, 2020
@epuertat epuertat added this to In progress in Dashboard via automation Nov 12, 2020
@epuertat epuertat moved this from In progress to Done in Dashboard Nov 12, 2020
@alfonsomthd alfonsomthd deleted the wip-47811-octopus branch December 23, 2020 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s0nea s0nea s0nea approved these changes

@avanthakkar avanthakkar avanthakkar approved these changes

@callithea callithea callithea approved these changes

@epuertat epuertat epuertat approved these changes

@aaSharma14 aaSharma14 Awaiting requested review from aaSharma14

@bk201 bk201 Awaiting requested review from bk201

Assignees
No one assigned
Labels
bug-fix dashboard TESTED
Projects
Ceph-Dashboard
Archived in project
Dashboard
  
Done
Milestone
octopus
5 participants
@alfonsomthd @callithea @s0nea @avanthakkar @epuertat