mgr/dashboard: replace cdCopy2ClipboardButton Directive with a component #37676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s0nea
added
needs-rebase
cleanup
skip-teuthology
prokopto-dev
force-pushed
the
fix-44960-master
branch
2 times, most recently
from
09916e7
to
8a27829
Compare
prokopto-dev
force-pushed
the
fix-44960-master
branch
from
8a27829
to
31feb7e
Compare
|
jenkins test make check |
|
fixing conflicts this morning and finishing updates to spec file; over-all functionality should be ready to review. |
alfonsomthd
requested changes
Nov 13, 2020
| @Directive({ | ||
| selector: '[cdCopy2ClipboardButton]' | ||
| @Component({ | ||
| selector: 'cdCopy2ClipboardButton', |
There was a problem hiding this comment.
All current selectors follow kebab-case (hyphen-case), such as: cd-my-component-selector.
For consistency this should be sth like: cd-copy2clipboard-button
There was a problem hiding this comment.
Roger that; I'll make that change!
alfonsomthd
requested changes
Nov 13, 2020
.../frontend/src/app/shared/components/copy2clipboard-button/copy2clipboard-button.component.ts
Outdated
Show resolved
Hide resolved
prokopto-dev
force-pushed
the
fix-44960-master
branch
from
31feb7e
to
9601266
Compare
prokopto-dev
force-pushed
the
fix-44960-master
branch
from
9601266
to
ff22734
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces Directive-Based copy2ClipboardButton with a Component-based version.
Further replaces all instances of Directive use with Component version.
Similar toastr logic used.
Fixes: https://tracker.ceph.com/issues/44960
Signed-off-by: Courtney Caldwell ccaldwel@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox