Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw : add MD5 in forward_request #37694

Merged
merged 1 commit into from Jan 25, 2021

Conversation

BryceCao
Copy link
Contributor

Fixes: https://tracker.ceph.com/issues/47869
Signed-off-by: caolei halei15848934852@163.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

Copy link
Contributor

@ofriedma ofriedma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@harishmunjulur
Copy link
Contributor

@harishmunjulur
Copy link
Contributor

@cbodley
Copy link
Contributor

cbodley commented Nov 20, 2020

seeing this crash in testing:

2020-11-20T00:16:37.479 INFO:teuthology.orchestra.run.smithi143.stderr: in thread 7f8007f3b0c0 thread_name:radosgw-admin
2020-11-20T00:16:37.479 INFO:teuthology.orchestra.run.smithi143.stderr:
2020-11-20T00:16:37.479 INFO:teuthology.orchestra.run.smithi143.stderr: ceph version 16.0.0-7352-gf65238c8 (f65238c87eab73928db788e2757a6f12f573cad8) pacific (dev)
2020-11-20T00:16:37.479 INFO:teuthology.orchestra.run.smithi143.stderr: 1: /lib/x86_64-linux-gnu/libpthread.so.0(+0x12980) [0x7f7ffd507980]
2020-11-20T00:16:37.480 INFO:teuthology.orchestra.run.smithi143.stderr: 2: gsignal()
2020-11-20T00:16:37.480 INFO:teuthology.orchestra.run.smithi143.stderr: 3: abort()
2020-11-20T00:16:37.480 INFO:teuthology.orchestra.run.smithi143.stderr: 4: /usr/lib/x86_64-linux-gnu/libstdc++.so.6(+0x8c957) [0x7f7ffc921957]
2020-11-20T00:16:37.480 INFO:teuthology.orchestra.run.smithi143.stderr: 5: /usr/lib/x86_64-linux-gnu/libstdc++.so.6(+0x92ae6) [0x7f7ffc927ae6]
2020-11-20T00:16:37.480 INFO:teuthology.orchestra.run.smithi143.stderr: 6: /usr/lib/x86_64-linux-gnu/libstdc++.so.6(+0x92b21) [0x7f7ffc927b21]
2020-11-20T00:16:37.481 INFO:teuthology.orchestra.run.smithi143.stderr: 7: /usr/lib/x86_64-linux-gnu/libstdc++.so.6(+0x92d54) [0x7f7ffc927d54]
2020-11-20T00:16:37.481 INFO:teuthology.orchestra.run.smithi143.stderr: 8: /usr/lib/x86_64-linux-gnu/libstdc++.so.6(+0x8e79f) [0x7f7ffc92379f]
2020-11-20T00:16:37.481 INFO:teuthology.orchestra.run.smithi143.stderr: 9: radosgw-admin(+0x68183e) [0x55ed0e94583e]
2020-11-20T00:16:37.481 INFO:teuthology.orchestra.run.smithi143.stderr: 10: (RGWRESTSimpleRequest::forward_request(RGWAccessKey&, req_info&, unsigned long, ceph::buffer::v15_2_0::list*, ceph::buffer::v15_2_0::list*, optional_yield)+0x3a3) [0x55ed0e94a953]
2020-11-20T00:16:37.481 INFO:teuthology.orchestra.run.smithi143.stderr: 11: (RGWRESTConn::forward(rgw_user const&, req_info&, obj_version*, unsigned long, ceph::buffer::v15_2_0::list*, ceph::buffer::v15_2_0::list*, optional_yield)+0x439) [0x55ed0e952159]
2020-11-20T00:16:37.482 INFO:teuthology.orchestra.run.smithi143.stderr: 12: radosgw-admin(+0x262ba7) [0x55ed0e526ba7]
2020-11-20T00:16:37.482 INFO:teuthology.orchestra.run.smithi143.stderr: 13: radosgw-admin(+0x265d81) [0x55ed0e529d81]
2020-11-20T00:16:37.482 INFO:teuthology.orchestra.run.smithi143.stderr: 14: radosgw-admin(+0x266644) [0x55ed0e52a644]
2020-11-20T00:16:37.482 INFO:teuthology.orchestra.run.smithi143.stderr: 15: main()
2020-11-20T00:16:37.483 INFO:teuthology.orchestra.run.smithi143.stderr: 16: __libc_start_main()
2020-11-20T00:16:37.483 INFO:teuthology.orchestra.run.smithi143.stderr: 17: _start()

@BryceCao
Copy link
Contributor Author

@cbodley have any detailed information about which “radosgw-admin ” command? please. Because the card isn't accessed for me.

@BryceCao BryceCao force-pushed the wip-add-MD5-in-forward_request branch from bb6a6e4 to 4dbf5f7 Compare December 31, 2020 02:40
Fixes: https://tracker.ceph.com/issues/47869
Signed-off-by: caolei <halei15848934852@163.com>
@BryceCao BryceCao force-pushed the wip-add-MD5-in-forward_request branch from 4dbf5f7 to 422a839 Compare December 31, 2020 05:48
@BryceCao
Copy link
Contributor Author

@cbodley the case of not passing MD5 caused null pointer before, I modified the code, add the check of the point.

@harishmunjulur harishmunjulur merged commit 80bf477 into ceph:master Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants