New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rgw : add MD5 in forward_request #37694
Merged
harishmunjulur
merged 1 commit into
ceph:master
from
BryceCao:wip-add-MD5-in-forward_request
Jan 25, 2021
Merged
rgw : add MD5 in forward_request #37694
harishmunjulur
merged 1 commit into
ceph:master
from
BryceCao:wip-add-MD5-in-forward_request
Jan 25, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofriedma
approved these changes
Oct 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
seeing this crash in testing:
|
@cbodley have any detailed information about which “radosgw-admin ” command? please. Because the card isn't accessed for me. |
BryceCao
force-pushed
the
wip-add-MD5-in-forward_request
branch
from
December 31, 2020 02:40
bb6a6e4
to
4dbf5f7
Compare
Fixes: https://tracker.ceph.com/issues/47869 Signed-off-by: caolei <halei15848934852@163.com>
BryceCao
force-pushed
the
wip-add-MD5-in-forward_request
branch
from
December 31, 2020 05:48
4dbf5f7
to
422a839
Compare
@cbodley the case of not passing MD5 caused null pointer before, I modified the code, add the check of the point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://tracker.ceph.com/issues/47869
Signed-off-by: caolei halei15848934852@163.com
Checklist
Show available Jenkins commands
jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox