Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nautilus: rbd: rbd-nbd: don't ignore namespace when unmapping by image spec #37811

Merged
merged 2 commits into from Nov 3, 2020
Merged

nautilus: rbd: rbd-nbd: don't ignore namespace when unmapping by image spec #37811

merged 2 commits into from Nov 3, 2020

Conversation

smithfarm
Copy link
Contributor

@smithfarm smithfarm commented Oct 26, 2020 •
edited

@trociny @smithfarm
qa/workunits/rbd: yet another attempt to improve rbd-nbd unmap
ec47657 
Previously it still could race when unmap_device returned success
because the device was not found in `rbd-nbd list-mapped` (the nbd
device was removed) but the test failed because the process was still
found in the ps table.

Fixes: https://tracker.ceph.com/issues/47394
Signed-off-by: Mykola Golub <mgolub@suse.com>
(cherry picked from commit f0c6976)

Conflicts:
	qa/workunits/rbd/rbd-nbd.sh
- omit changes in tests that are not in nautilus
@trociny @smithfarm
rbd-nbd: don't ignore namespace when unmapping by image spec
538ac73 
Fixes: https://tracker.ceph.com/issues/47665
Signed-off-by: Mykola Golub <mgolub@suse.com>
(cherry picked from commit b360186)
@smithfarm smithfarm added this to the nautilus milestone Oct 26, 2020
@smithfarm smithfarm added the rbd label Oct 26, 2020
@smithfarm smithfarm changed the title nautilus: rbd-nbd: don't ignore namespace when unmapping by image spec nautilus: rbd: rbd-nbd: don't ignore namespace when unmapping by image spec Oct 26, 2020
dillaman
dillaman approved these changes Oct 26, 2020
View reviewed changes
Copy link

@dillaman dillaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@smithfarm smithfarm added nautilus-batch-1 nautilus point releases needs-qa labels Oct 26, 2020
@yuriw yuriw merged commit 4a9955a into ceph:nautilus Nov 3, 2020
@smithfarm smithfarm deleted the wip-47703-nautilus branch November 4, 2020 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trociny trociny trociny approved these changes

@dillaman dillaman dillaman approved these changes

Assignees
No one assigned
Labels
nautilus-batch-1 nautilus point releases needs-qa rbd wip-yuri6-testing
Projects
None yet
Milestone
nautilus
4 participants
@smithfarm @trociny @dillaman @yuriw