librbd: global config overrides do not apply to in-use images #37894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method was previously only available for seastart builds, but librbd will also use it to control the timing of updates to the global config. Signed-off-by: Jason Dillaman <dillaman@redhat.com>
trociny
reviewed
Oct 29, 2020
| void set_config_values(const ConfigValues& val) { | ||
| #ifndef WITH_SEASTAR |
There was a problem hiding this comment.
Just wondering, do we really need this #ifndef WITH_SEASTAR? Wouldn't the lock work for seastar too?
There was a problem hiding this comment.
They try to avoid all locking in seastar -- I think that's why there are those 100% unsafe operator-> overloads.
added 2 commits
October 29, 2020 14:14
Expose the ability to retrieve the ConfigValues from an existing ConfigProxy object. When combined with the newly exposed 'set_config_values' method, it will allow the safe bulk-updating of configuration options. This also removes the original private static version of 'get_config_values'. Signed-off-by: Jason Dillaman <dillaman@redhat.com>
The ConfigProxy contains a point-in-time copy of the global config that is dynamically updated in CephContext::_conf. Upon an image refresh, pull the latest version of the global config from the CephContext and apply it to the config stored within the ImageCtx. Fixes: https://tracker.ceph.com/issues/48035 Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox