rgw : catch non int exception #37926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@batrick , sorry, i close last PR by mistake, please label it again. |
BryceCao
force-pushed
the
wip-catch-non-int-exception
branch
from
0caaaa2
to
6c8ae90
Compare
3 tasks
dang
reviewed
Nov 6, 2020
src/rgw/rgw_auth.cc
Outdated
| ldpp_dout(dpp, 5) << "applier throwed unexpected err: " << e.what() | ||
| << dendl; | ||
| return -EPERM; | ||
| } catch (...) { |
There was a problem hiding this comment.
The ... catch shouldn't be necessary, since std::exception should catch everything, right?
There was a problem hiding this comment.
Shouldn't be in general unless there's some exception class that doesn't inherit from std::exception (I don't know if there's any such class involved here).
There was a problem hiding this comment.
I checked the code here again. Actually, there would be two kinds of errors: int and std::exception, so i remove the part of catch (...).
Fixes: https://tracker.ceph.com/issues/48034 Signed-off-by: caolei <halei15848934852@163.com>
BryceCao
force-pushed
the
wip-catch-non-int-exception
branch
from
6c8ae90
to
bfd20a5
Compare
|
jenkins test make check |
dang
approved these changes
Nov 9, 2020
|
@cbodley do we think this needs Teuthology? |
This was referenced Feb 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://tracker.ceph.com/issues/48034
Signed-off-by: caolei halei15848934852@163.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox