Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qa/mgr: mgr_test_case: raise SkipTest instead of calling skipTest() #37992

Merged
merged 1 commit into from
Nov 15, 2020
Merged

qa/mgr: mgr_test_case: raise SkipTest instead of calling skipTest() #37992

merged 1 commit into from
Nov 15, 2020

Conversation

rishabh-d-dave
Copy link
Contributor

@rishabh-d-dave rishabh-d-dave commented Nov 9, 2020 •
edited

skipTest() is being used as a class method which is not correct since it's an instance method. Replace call to skipTest() by a raising SkipTest instead.

Fixes: https://tracker.ceph.com/issues/48152

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@rishabh-d-dave rishabh-d-dave requested a review from a team November 9, 2020 11:08
This was referenced Nov 9, 2020
Merged
Merged
@rishabh-d-dave
Copy link
Contributor Author

jenkins test make check

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Nov 9, 2020 •
edited

About last update: created a tracker ticket and added a reference to the ticket in the commit and the PR description.
Link to last test results - https://jenkins.ceph.com/job/ceph-api/6370/.

@alfonsomthd
Copy link
Contributor

@rishabh-d-dave For what I see here:
https://jenkins.ceph.com/job/ceph-api/6377/consoleText
All affected tests are now skipped with messages like:
skipped 'Only have 3 manager daemons, 1 are required'. Can you please take a look?

2020-11-09 13:41:23,017.017 INFO:__main__:Starting test: test_crash (tasks.mgr.test_module_selftest.TestModuleSelftest)
2020-11-09 13:41:23,018.018 INFO:__main__:Stopped test: test_crash (tasks.mgr.test_module_selftest.TestModuleSelftest) in 0.000356s
2020-11-09 13:41:23,018.018 INFO:__main__:Starting test: test_devicehealth (tasks.mgr.test_module_selftest.TestModuleSelftest)
2020-11-09 13:41:23,019.019 INFO:__main__:test_validate_password_ok (tasks.mgr.dashboard.test_user.UserTest) ... skipped 'Only have 3 manager daemons, 2 are required'
2020-11-09 13:41:23,019.019 INFO:__main__:test_validate_password_strong (tasks.mgr.dashboard.test_user.UserTest) ... skipped 'Only have 3 manager daemons, 2 are required'
2020-11-09 13:41:23,019.019 INFO:__main__:test_validate_password_very_strong (tasks.mgr.dashboard.test_user.UserTest) ... skipped 'Only have 3 manager daemons, 2 are required'
2020-11-09 13:41:23,019.019 INFO:__main__:test_validate_password_weak (tasks.mgr.dashboard.test_user.UserTest) ... skipped 'Only have 3 manager daemons, 2 are required'
2020-11-09 13:41:23,019.019 INFO:__main__:test_crash (tasks.mgr.test_module_selftest.TestModuleSelftest) ... skipped 'Only have 3 manager daemons, 1 are required'
2020-11-09 13:41:23,019.019 INFO:__main__:test_devicehealth (tasks.mgr.test_module_selftest.TestModuleSelftest) ... skipped 'Only have 3 manager daemons, 1 are required'
2020-11-09 13:41:23,019.019 INFO:__main__:
2020-11-09 13:41:23,020.020 INFO:__main__:Stopped test: test_devicehealth (tasks.mgr.test_module_selftest.TestModuleSelftest) in 0.000936s
2020-11-09 13:41:23,020.020 INFO:__main__:Starting test: test_diskprediction_local (tasks.mgr.test_module_selftest.TestModuleSelftest)
2020-11-09 13:41:23,020.020 INFO:__main__:Stopped test: test_diskprediction_local (tasks.mgr.test_module_selftest.TestModuleSelftest) in 6.5e-05s
2020-11-09 13:41:23,020.020 INFO:__main__:Starting test: test_influx (tasks.mgr.test_module_selftest.TestModuleSelftest)
2020-11-09 13:41:23,020.020 INFO:__main__:Stopped test: test_influx (tasks.mgr.test_module_selftest.TestModuleSelftest) in 5.6e-05s
2020-11-09 13:41:23,020.020 INFO:__main__:Starting test: test_iostat (tasks.mgr.test_module_selftest.TestModuleSelftest)
2020-11-09 13:41:23,020.020 INFO:__main__:Stopped test: test_iostat (tasks.mgr.test_module_selftest.TestModuleSelftest) in 5e-05s
2020-11-09 13:41:23,020.020 INFO:__main__:Starting test: test_module_commands (tasks.mgr.test_module_selftest.TestModuleSelftest)
2020-11-09 13:41:23,020.020 INFO:__main__:Stopped test: test_module_commands (tasks.mgr.test_module_selftest.TestModuleSelftest) in 5.7e-05s
2020-11-09 13:41:23,021.021 INFO:__main__:Starting test: test_module_remote (tasks.mgr.test_module_selftest.TestModuleSelftest)
2020-11-09 13:41:23,021.021 INFO:__main__:Stopped test: test_module_remote (tasks.mgr.test_module_selftest.TestModuleSelftest) in 4.9e-05s
2020-11-09 13:41:23,021.021 INFO:__main__:Starting test: test_orchestrator (tasks.mgr.test_module_selftest.TestModuleSelftest)
2020-11-09 13:41:23,021.021 INFO:__main__:test_diskprediction_local (tasks.mgr.test_module_selftest.TestModuleSelftest) ... skipped 'Only have 3 manager daemons, 1 are required'
2020-11-09 13:41:23,021.021 INFO:__main__:test_influx (tasks.mgr.test_module_selftest.TestModuleSelftest) ... skipped 'Only have 3 manager daemons, 1 are required'
2020-11-09 13:41:23,021.021 INFO:__main__:test_iostat (tasks.mgr.test_module_selftest.TestModuleSelftest) ... skipped 'Only have 3 manager daemons, 1 are required'
2020-11-09 13:41:23,021.021 INFO:__main__:test_module_commands (tasks.mgr.test_module_selftest.TestModuleSelftest) ... skipped 'Only have 3 manager daemons, 1 are required'
2020-11-09 13:41:23,021.021 INFO:__main__:test_module_remote (tasks.mgr.test_module_selftest.TestModuleSelftest) ... skipped 'Only have 3 manager daemons, 1 are required'
2020-11-09 13:41:23,021.021 INFO:__main__:test_orchestrator (tasks.mgr.test_module_selftest.TestModuleSelftest) ... skipped 'Only have 3 manager daemons, 1 are required'
2020-11-09 13:41:23,021.021 INFO:__main__:
2020-11-09 13:41:23,021.021 INFO:__main__:Stopped test: test_orchestrator (tasks.mgr.test_module_selftest.TestModuleSelftest) in 0.00055s
2020-11-09 13:41:23,022.022 INFO:__main__:Starting test: test_prometheus (tasks.mgr.test_module_selftest.TestModuleSelftest)
2020-11-09 13:41:23,022.022 INFO:__main__:Stopped test: test_prometheus (tasks.mgr.test_module_selftest.TestModuleSelftest) in 4.9e-05s
2020-11-09 13:41:23,022.022 INFO:__main__:Starting test: test_selftest_cluster_log (tasks.mgr.test_module_selftest.TestModuleSelftest)
2020-11-09 13:41:23,022.022 INFO:__main__:Stopped test: test_selftest_cluster_log (tasks.mgr.test_module_selftest.TestModuleSelftest) in 5e-05s
2020-11-09 13:41:23,022.022 INFO:__main__:Starting test: test_selftest_cluster_log_unknown_channel (tasks.mgr.test_module_selftest.TestModuleSelftest)
2020-11-09 13:41:23,022.022 INFO:__main__:Stopped test: test_selftest_cluster_log_unknown_channel (tasks.mgr.test_module_selftest.TestModuleSelftest) in 5.4e-05s
2020-11-09 13:41:23,022.022 INFO:__main__:Starting test: test_selftest_command_spam (tasks.mgr.test_module_selftest.TestModuleSelftest)
2020-11-09 13:41:23,022.022 INFO:__main__:Stopped test: test_selftest_command_spam (tasks.mgr.test_module_selftest.TestModuleSelftest) in 5.3e-05s
2020-11-09 13:41:23,022.022 INFO:__main__:Starting test: test_selftest_config_update (tasks.mgr.test_module_selftest.TestModuleSelftest)
2020-11-09 13:41:23,023.023 INFO:__main__:Stopped test: test_selftest_config_update (tasks.mgr.test_module_selftest.TestModuleSelftest) in 5.6e-05s
2020-11-09 13:41:23,023.023 INFO:__main__:Starting test: test_selftest_config_upgrade (tasks.mgr.test_module_selftest.TestModuleSelftest)
2020-11-09 13:41:23,023.023 INFO:__main__:test_prometheus (tasks.mgr.test_module_selftest.TestModuleSelftest) ... skipped 'Only have 3 manager daemons, 1 are required'
2020-11-09 13:41:23,023.023 INFO:__main__:test_selftest_cluster_log (tasks.mgr.test_module_selftest.TestModuleSelftest) ... skipped 'Only have 3 manager daemons, 1 are required'
2020-11-09 13:41:23,023.023 INFO:__main__:test_selftest_cluster_log_unknown_channel (tasks.mgr.test_module_selftest.TestModuleSelftest) ... skipped 'Only have 3 manager daemons, 1 are required'
2020-11-09 13:41:23,023.023 INFO:__main__:test_selftest_command_spam (tasks.mgr.test_module_selftest.TestModuleSelftest) ... skipped 'Only have 3 manager daemons, 1 are required'
2020-11-09 13:41:23,023.023 INFO:__main__:test_selftest_config_update (tasks.mgr.test_module_selftest.TestModuleSelftest) ... skipped 'Only have 3 manager daemons, 1 are required'
2020-11-09 13:41:23,023.023 INFO:__main__:test_selftest_config_upgrade (tasks.mgr.test_module_selftest.TestModuleSelftest) ... skipped 'Only have 3 manager daemons, 1 are required'
2020-11-09 13:41:23,023.023 INFO:__main__:
2020-11-09 13:41:23,023.023 INFO:__main__:Stopped test: test_selftest_config_upgrade (tasks.mgr.test_module_selftest.TestModuleSelftest) in 0.000549s
2020-11-09 13:41:23,023.023 INFO:__main__:Starting test: test_selftest_run (tasks.mgr.test_module_selftest.TestModuleSelftest)
2020-11-09 13:41:23,023.023 INFO:__main__:Stopped test: test_selftest_run (tasks.mgr.test_module_selftest.TestModuleSelftest) in 4.5e-05s
2020-11-09 13:41:23,024.024 INFO:__main__:Starting test: test_telegraf (tasks.mgr.test_module_selftest.TestModuleSelftest)
2020-11-09 13:41:23,024.024 INFO:__main__:Stopped test: test_telegraf (tasks.mgr.test_module_selftest.TestModuleSelftest) in 5e-05s
2020-11-09 13:41:23,024.024 INFO:__main__:Starting test: test_telemetry (tasks.mgr.test_module_selftest.TestModuleSelftest)
2020-11-09 13:41:23,024.024 INFO:__main__:Stopped test: test_telemetry (tasks.mgr.test_module_selftest.TestModuleSelftest) in 4.8e-05s
2020-11-09 13:41:23,024.024 INFO:__main__:Starting test: test_zabbix (tasks.mgr.test_module_selftest.TestModuleSelftest)
2020-11-09 13:41:23,024.024 INFO:__main__:Stopped test: test_zabbix (tasks.mgr.test_module_selftest.TestModuleSelftest) in 5.1e-05s
2020-11-09 13:41:23,024.024 INFO:__main__:test_selftest_run (tasks.mgr.test_module_selftest.TestModuleSelftest) ... skipped 'Only have 3 manager daemons, 1 are required'
2020-11-09 13:41:23,024.024 INFO:__main__:test_telegraf (tasks.mgr.test_module_selftest.TestModuleSelftest) ... skipped 'Only have 3 manager daemons, 1 are required'
2020-11-09 13:41:23,024.024 INFO:__main__:test_telemetry (tasks.mgr.test_module_selftest.TestModuleSelftest) ... skipped 'Only have 3 manager daemons, 1 are required'
2020-11-09 13:41:23,025.025 INFO:__main__:test_zabbix (tasks.mgr.test_module_selftest.TestModuleSelftest) ... skipped 'Only have 3 manager daemons, 1 are required'
2020-11-09 13:41:23,025.025 INFO:__main__:
2020-11-09 13:41:23,025.025 INFO:__main__:----------------------------------------------------------------------
2020

@rishabh-d-dave
Copy link
Contributor Author

Evidently, I applied wrong patch. Fixed in latest push, tests should pass now.

@tchaikov
Copy link
Contributor

tchaikov commented Nov 9, 2020

could you update the commit message accordingly?

@rishabh-d-dave
qa/mgr: mgr_test_case: raise SkipTest instead of calling skipTest()
eb70274 
skipTest() is being used as a class method which is not correct since
it's an instance method. Replace call to skipTest() by a raising
SkipTest instead.

Fixes: https://tracker.ceph.com/issues/48152
Signed-off-by: Rishabh Dave <ridave@redhat.com>
@rishabh-d-dave
Copy link
Contributor Author

Changed.

@alfonsomthd
Copy link
Contributor

@rishabh-d-dave @tchaikov The API test error do not seem related to this PR:
#37997

@tchaikov tchaikov changed the title qa/mgr: mgr_test_case: use skipTest() is an instance method qa/mgr: mgr_test_case: raise SkipTest instead of calling skipTest() Nov 9, 2020
@alfonsomthd
Copy link
Contributor

jenkins test api

@rishabh-d-dave
Copy link
Contributor Author

I was just about retest. Thanks!

@s0nea
Copy link
Member

s0nea commented Nov 10, 2020

jenkins test api

@rishabh-d-dave
Copy link
Contributor Author

@alfonsomthd @s0nea @votdev All tests passed.

@rishabh-d-dave
Copy link
Contributor Author

@votdev @ceph/dashboard Can we please merge this PR? I have a couple of PRs that depend on this one. Thanks!

@tchaikov
Copy link
Contributor

tchaikov commented Nov 15, 2020 •
edited

failures tracked by

@tchaikov tchaikov merged commit f7962b1 into ceph:master Nov 15, 2020
@rishabh-d-dave
Copy link
Contributor Author

Thanks @tchaikov!

@rishabh-d-dave rishabh-d-dave deleted the dashboard-qa-skipTest branch November 18, 2020 04:45
@rishabh-d-dave
Copy link
Contributor Author

@tchaikov I've set the status for the tracker ticket of this PR as Resolved. But I must confirm with you on whether we require backports for this PR or not.

@tchaikov
Copy link
Contributor

@rishabh-d-dave i'd backport it.

@rishabh-d-dave rishabh-d-dave mentioned this pull request Nov 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tchaikov tchaikov tchaikov approved these changes

@alfonsomthd alfonsomthd alfonsomthd approved these changes

@votdev votdev Awaiting requested review from votdev

Assignees
No one assigned
Labels
bug-fix dashboard needs-qa needs-review tests wip-kefu-testing
Projects
None yet
Milestone
No milestone
4 participants
@rishabh-d-dave @alfonsomthd @tchaikov @s0nea