Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc/rados/configuration/common.rst: enhance the running multiple clusters section #38079

Merged
merged 1 commit into from Nov 25, 2020
Merged

doc/rados/configuration/common.rst: enhance the running multiple clusters section #38079

merged 1 commit into from Nov 25, 2020

Conversation

anthonyeleven
Copy link
Contributor

@anthonyeleven anthonyeleven commented Nov 14, 2020

doc/rados/configuration: enhance the running multiple clusters section for tracker 24143

Add context to the existing note that running custom names, and thus
multiple clusters on the same hardware, are both deprecated and should
not be done. This should fulfill tracker 24143.

Also correct the existing text that mistook the -c CLI option (config file) for --cluster, and capitalize Ceph in CONTRIBUTING.rst.

Fixes: https://tracker.ceph.com/issues/24143
Signed-off-by: Anthony D'Atri anthony.datri@gmail.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@anthonyeleven anthonyeleven changed the title doc/rados/configuration/common.rst: expand the running multiple clusters section doc/rados/configuration/common.rst: enhance the running multiple clusters section Nov 14, 2020
…ers section

Add context to the existing note that running custom names, and thus
multiple clusters on the same hardware, are both deprecated and should
not be done.  This should fulfill tracker #24143.

Fixes: https://tracker.ceph.com/issues/24143
Signed-off-by: Anthony D'Atri <anthony.datri@gmail.com>

fix flag
@anthonyeleven
Copy link
Contributor Author

@zdover23 PTAL

Copy link
Contributor

@zdover23 zdover23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zdover23 zdover23 merged commit 3cea1e5 into ceph:master Nov 25, 2020
@anthonyeleven anthonyeleven deleted the anthonyeleven/docs-24143 branch November 26, 2020 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants