Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc/releases: correct spelling #38090

Merged
merged 1 commit into from Nov 22, 2020
Merged

doc/releases: correct spelling #38090

merged 1 commit into from Nov 22, 2020

Conversation

anthonyeleven
Copy link
Contributor

@anthonyeleven anthonyeleven commented Nov 16, 2020

doc/releases: correct spelling

Fixes: https://tracker.ceph.com/issues/47339
Signed-off-by: Anthony D'Atri anthony.datri@gmail.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@anthonyeleven
Copy link
Contributor Author

anthonyeleven commented Nov 16, 2020

@zdover23 Should I be miffed that my name is spelled incorrectly within the text?

@anthonyeleven anthonyeleven changed the title doc/releases: Address tracker #47339 doc/releases: Spelling correction Nov 20, 2020
@anthonyeleven
Copy link
Contributor Author

jenkins test api

@anthonyeleven
Copy link
Contributor Author

jenkins make check

@anthonyeleven
Copy link
Contributor Author

jenkins test make check

@tchaikov tchaikov changed the title doc/releases: Spelling correction doc/releases: correct spelling Nov 21, 2020
@tchaikov
Copy link
Contributor

@anthonyeleven i revised the title of your commit message. ideally, the title of the commit message should use the imperative mood. see also https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#3-describe-your-changes . please use git commit --amend and git push -f for revising the commit message and its title.

Fixes: https://tracker.ceph.com/issues/47339
Signed-off-by: Anthony D'Atri <anthony.datri@gmail.com>
@anthonyeleven
Copy link
Contributor Author

@tchaikov I've updated this PR again. I know the process; I applied it to most of my 11 open PRs on Thursday night. Any other changes I need to make? For many of the outstanding PRs that address tracker tickets I used the exact text in the tracker. If I need to reword those too, please let me know.

@tchaikov
Copy link
Contributor

Any other changes I need to make?

@anthonyeleven thanks. no other changes needed.

For many of the outstanding PRs that address tracker tickets I used the exact text in the tracker. If I need to reword those too, please let me know.

this convention only applies to the commit messages. and the the tracker tickets are used for tracking the issues or the TODO itmes. so i think they are good =)

@tchaikov tchaikov merged commit d3cf17d into ceph:master Nov 22, 2020
@anthonyeleven
Copy link
Contributor Author

Okay thanks. I always like to know how to get these right the first time.

@anthonyeleven anthonyeleven deleted the anthonyeleven/docs-47339 branch November 22, 2020 06:15
@anthonyeleven anthonyeleven restored the anthonyeleven/docs-47339 branch November 22, 2020 06:47
@anthonyeleven anthonyeleven deleted the anthonyeleven/docs-47339 branch November 26, 2020 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants