Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os/bluestore: do not call _block_picker() again if already searched from start() #38148

Merged
merged 1 commit into from Nov 22, 2020
Merged

os/bluestore: do not call _block_picker() again if already searched from start() #38148

merged 1 commit into from Nov 22, 2020

Conversation

jhonxue
Copy link
Contributor

@jhonxue jhonxue commented Nov 18, 2020 •
edited

os/bluestore: do not call _block_picker() again if already searched from start()

Fixes: https://tracker.ceph.com/issues/48272

Signed-off-by: Xue Yantao jhonxue@tencent.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@github-actions github-actions bot added the core label Nov 18, 2020
@tchaikov tchaikov changed the title osd: bluestore avl allocator can avoid another _block_picker os/bluestore: do not call _block_picker() again if already searched from start() Nov 18, 2020
tchaikov
tchaikov requested changes Nov 18, 2020
View reviewed changes
Copy link
Contributor

@tchaikov tchaikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you update the title of the commit message accordingly. IMHO, it's not a fix, but a cleanup for the corner case where we are out of space.

@jhonxue
Copy link
Contributor Author

jhonxue commented Nov 18, 2020

could you update the title of the commit message accordingly. IMHO, it's not a fix, but a cleanup for the corner case where we are out of space.

ok,i will. thanks

@jhonxue jhonxue force-pushed the wip-fix-bluestore-avl-allocator branch from 0bfff57 to fd5ca26 Compare November 18, 2020 10:06
@jhonxue
Copy link
Contributor Author

jhonxue commented Nov 18, 2020

@xiexingguo please, review. thanks

@jhonxue
Copy link
Contributor Author

jhonxue commented Nov 18, 2020

@tchaikov please, review again. thanks

@tchaikov
Copy link
Contributor

@tchaikov tchaikov merged commit 57f385f into ceph:master Nov 22, 2020
@mfoliveira mfoliveira mentioned this pull request Oct 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tchaikov tchaikov tchaikov approved these changes

@xiexingguo xiexingguo Awaiting requested review from xiexingguo

Assignees
No one assigned
Labels
bluestore core needs-qa wip-kefu-testing
Projects
None yet
Milestone
No milestone
3 participants
@jhonxue @tchaikov @neha-ojha