mon: paxos: Delete logger in destructor #38314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the failure of "mon-last-epoch-clean.sh" is addressed by #38239 |
|
@tchaikov Thanks for testing this. |
tchaikov
reviewed
Nov 30, 2020
badone
force-pushed
the
wip-monitor-reset-abort-if-is_shutdown
branch
from
e695ec8
to
439b7e8
Compare
badone
force-pushed
the
wip-monitor-reset-abort-if-is_shutdown
branch
from
439b7e8
to
087af9f
Compare
tchaikov
reviewed
Dec 1, 2020
tchaikov
approved these changes
Dec 1, 2020
reset() can race with shutdown() leading to a use-after-free on the 'logger' object. Fixes: https://tracker.ceph.com/issues/48386 Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
badone
force-pushed
the
wip-monitor-reset-abort-if-is_shutdown
branch
from
087af9f
to
cc295d1
Compare
badone
changed the title
This was referenced Jan 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reset() can race with shutdown() leading to a use-after-free on the
'logger' object.
Fixes: https://tracker.ceph.com/issues/48386
Signed-off-by: Brad Hubbard bhubbard@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox