osd : prevent accessing deleted reference #38576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myoungwon
force-pushed
the
wip-fix-seg-fault-manifest-count
branch
from
4a9b41f
to
2ac9db7
Compare
cb in C_SetManifestRefCountDone() was freed during cancel_manifest_ops(). After that, ~C_SetManifestRefCountDone() try to free the cb because the cb is not nullptr. This commit prevents calling a deleted reference. Fixes: https://tracker.ceph.com/issues/48599 Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
myoungwon
force-pushed
the
wip-fix-seg-fault-manifest-count
branch
from
2ac9db7
to
b839203
Compare
athanatos
approved these changes
Dec 15, 2020
|
@athanatos @neha-ojha What do you think? |
|
@myoungwon @athanatos @neha-ojha i am merging it anyway as this PR addresses a test failure in teuthology based test, also, it has been approved and tested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cb in C_SetManifestRefCountDone() was freed
during cancel_manifest_ops(). After that,
~C_SetManifestRefCountDone() try to free the cb
because the cb is not nullptr.
This commit prevents calling a deleted reference.
Fixes: https://tracker.ceph.com/issues/48599
Signed-off-by: Myoungwon Oh myoungwon.oh@samsung.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox