Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

librbd: ensure stripe unit is at least 512 bytes #38655

Merged
merged 1 commit into from Dec 30, 2020
Merged

librbd: ensure stripe unit is at least 512 bytes #38655

merged 1 commit into from Dec 30, 2020

Conversation

dillaman
Copy link

Fixes: https://tracker.ceph.com/issues/47828
Signed-off-by: Jason Dillaman dillaman@redhat.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

librbd: ensure stripe unit is at least 512 bytes
4167c5d 
Fixes: https://tracker.ceph.com/issues/47828
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
trociny
trociny approved these changes Dec 18, 2020
View reviewed changes
Copy link
Contributor

@trociny trociny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ddiss
ddiss approved these changes Dec 18, 2020
View reviewed changes
Copy link
Contributor

@ddiss ddiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: conditions above drop the != 0 for non-zero stripe_unit checks, so might want to change that for consistency. Looks fine as is though.
I take it there's no need to throw a warning when mapping an existing image with stripe_unit < 512.

@trociny
Copy link
Contributor

trociny commented Dec 21, 2020

jenkins test make check

@trociny trociny merged commit 1bfac61 into ceph:master Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trociny trociny trociny approved these changes

@ddiss ddiss ddiss approved these changes

Assignees
No one assigned
Labels
bug-fix rbd wip-mgolub-testing
Projects
None yet
Milestone
No milestone
3 participants
@dillaman @trociny @ddiss