Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rgw: fix 'this->ondisk_version' will always evaluate to 'true' #38674

Merged
merged 1 commit into from Dec 21, 2020
Merged

rgw: fix 'this->ondisk_version' will always evaluate to 'true' #38674

merged 1 commit into from Dec 21, 2020

Conversation

mkogan1
Copy link
Contributor

@mkogan1 mkogan1 commented Dec 21, 2020 •
edited

fix:

src/rgw/CMakeFiles/radosgw.dir/rgw_rest_metadata.cc.o
../src/rgw/rgw_rest_metadata.cc:267:13: warning: address of
'this->ondisk_version' will always evaluate to 'true'
[-Wpointer-bool-conversion]
                                       &ondisk_version);

Fixes: https://tracker.ceph.com/issues/48688

Signed-off-by: Mark Kogan mkogan@redhat.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@mkogan1
rgw: fix 'this->ondisk_version' will always evaluate to 'true'
6fd551b 
fix:
```
src/rgw/CMakeFiles/radosgw.dir/rgw_rest_metadata.cc.o
../src/rgw/rgw_rest_metadata.cc:267:13: warning: address of
'this->ondisk_version' will always evaluate to 'true'
[-Wpointer-bool-conversion]
                                       &ondisk_version);
```
Fixes: https://tracker.ceph.com/issues/48688

Signed-off-by: Mark Kogan <mkogan@redhat.com>
@mkogan1
Copy link
Contributor Author

mkogan1 commented Dec 21, 2020

jenkins test make check

@cbodley cbodley merged commit b235c9a into ceph:master Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbodley cbodley cbodley approved these changes

@ronen-fr ronen-fr ronen-fr approved these changes

Assignees
No one assigned
Labels
bug-fix rgw
Projects
None yet
Milestone
No milestone
3 participants
@mkogan1 @cbodley @ronen-fr