osd: coalesce into single omap_setkeys for normal writes #3878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SUCCESS: the output of run-make-check.sh on centos-7 for 063180c is http://paste2.org/XgsJb0tb |
Sent from 
|
LGTM...The ceph-objectstore-tool passed unit test too. merge? |
|
this should go through a qa run first, if it hasn't already
|
|
Confirmation: I have integrated with 0.93 source and re-tested. For a random write test with 4KByte buffer size, the CPU consumption for the FileStore workers is reduced by 22% and the overall CPU consumption for the ceph-osd daemon is reduced by 10%. |
No real change yet. Signed-off-by: Sage Weil <sage@redhat.com>
This saves a surprising amount of CPU. Signed-off-by: Sage Weil <sage@redhat.com>
The pg_log.add() call already dirties the log such that the later write_log() call will write it. There is no need to encode it separately here and then explicitly omap_setkeys() it. Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
force-pushed
the
wip-dirty-pg-keys
branch
from
4d1c776
to
edf64dd
Compare
liewegas
changed the title
liewegas
added a commit
that referenced
this pull request
Mar 30, 2015
osd: coalesce into single omap_setkeys for normal writes Tested-by: Andreas Bluemle <andreas.bluemle@itxperts.de> Reviewed-by: David Zafman <dzafman@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.