New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
osd: handle ceph specific config changes for the mclock scheduler #38920
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice and easy to read!
fd0f2e1
to
065d18e
Compare
065d18e
to
6b834aa
Compare
jenkins test api |
jenkins retest this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The below ceph parameters are set automatically while enabling the mclock scheduler with a built-in profile. The user in this case will not be able to modify these ceph specific config options during runtime. a. osd_async_recovery_min_cost b. osd_recovery_max_active{_hdd,_ssd} c. osd_max_backfills d. osd_recovery_sleep{_hdd,_ssd,_hybrid} If the custom profile is enabled for the mclock scheduler, the user can modify these parameters. Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
6b834aa
to
e0f0837
Compare
https://pulpito.ceph.com/nojha-2021-01-16_20:47:46-rados-wip-config-sets-ci-distro-basic-smithi/ - https://tracker.ceph.com/issues/48906 is a known issue and will be addressed in a follow-on PR. |
@jdurgin @neha-ojha I noticed that this PR (which was merged on January 17) is in the pacific branch. Indeed, the pacific branch is identical to master even today. Wasn't it supposed to be split off on January 15? |
Well, nevermind I guess - after reading https://docs.ceph.com/en/latest/dev/developer_guide/merging/ I realized that cherry-picking to pacific cannot start until Phase 2 - https://docs.ceph.com/en/latest/dev/developer_guide/merging/#stable-release-candidates-i-e-x-1-z-phase-2 - starts, and for that to happen pacific needs a 16.1.x tag which it doesn't have yet. |
The below ceph parameters are set automatically
while enabling the mclock scheduler with a built-in profile.
The user in this case will not be able to modify these
ceph specific config options during runtime.
a. osd_async_recovery_min_cost
b. osd_recovery_max_active{_hdd,_ssd}
c. osd_max_backfills
d. osd_recovery_sleep{_hdd,_ssd,_hybrid}
If the custom profile is enabled for the mclock scheduler,
the user can modify these parameters.
Signed-off-by: Sunny Kumar sunkumar@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox