Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

An empty bucket or OSD is not an error #38958

Merged
merged 2 commits into from Jan 25, 2021
Merged

An empty bucket or OSD is not an error #38958

merged 2 commits into from Jan 25, 2021

Conversation

badone
Copy link
Contributor

@badone badone commented Jan 19, 2021 •
edited

Fixes: https://tracker.ceph.com/issues/48884

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@github-actions github-actions bot added the tests label Jan 19, 2021
@badone badone added the DNM label Jan 20, 2021
@badone
Copy link
Contributor Author

badone commented Jan 20, 2021

Changing the test here to be more robust.

@badone
test/osd: Verify print_osd_utilization output
3dc72a0 
Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
@badone
osd/OSDMap: An empty bucket or OSD is not an error
4f07cff 
Fixes: https://tracker.ceph.com/issues/48884

Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
@badone badone force-pushed the wip-osd-df-tree-accounting-error branch from c131ce4 to 4f07cff Compare January 21, 2021 03:16
@badone
Copy link
Contributor Author

badone commented Jan 21, 2021

@jdurgin How about this?

jdurgin
jdurgin approved these changes Jan 21, 2021
View reviewed changes
Copy link
Member

@jdurgin jdurgin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That json-handling in c++ turned out much nicer than I expected!

@badone
Copy link
Contributor Author

badone commented Jan 21, 2021

That json-handling in c++ turned out much nicer than I expected!

Yeah, quite happy with the result. Thanks!

@badone badone added needs-qa and removed DNM labels Jan 21, 2021
@ideepika
Copy link
Member

http://pulpito.front.sepia.ceph.com/ideepika-2021-01-22_07:01:14-rados-wip-deepika-testing-master-2021-01-22-0047-distro-basic-smithi/
rerun: http://pulpito.front.sepia.ceph.com/ideepika-2021-01-25_12:19:15-rados-wip-deepika-testing-2021-01-25-1527-distro-basic-smithi/
failure not related and tracked by:
https://tracker.ceph.com/issues/48981
https://tracker.ceph.com/issues/48982

1 similar comment
@ideepika
Copy link
Member

http://pulpito.front.sepia.ceph.com/ideepika-2021-01-22_07:01:14-rados-wip-deepika-testing-master-2021-01-22-0047-distro-basic-smithi/
rerun: http://pulpito.front.sepia.ceph.com/ideepika-2021-01-25_12:19:15-rados-wip-deepika-testing-2021-01-25-1527-distro-basic-smithi/
failure not related and tracked by:
https://tracker.ceph.com/issues/48981
https://tracker.ceph.com/issues/48982

@neha-ojha neha-ojha merged commit 71a6508 into ceph:master Jan 25, 2021
@smithfarm smithfarm mentioned this pull request Jan 28, 2021
Merged
@singuliere singuliere mentioned this pull request Mar 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdurgin jdurgin jdurgin approved these changes

Assignees
No one assigned
Labels
bug-fix core tests
Projects
None yet
Milestone
No milestone
4 participants
@badone @ideepika @jdurgin @neha-ojha