cephadm: fix 2> syntax in unit.run #39003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgfritch
approved these changes
Jan 21, 2021
dsavineau
approved these changes
Jan 21, 2021
sebastian-philipp
approved these changes
Jan 21, 2021
This was referenced Jan 22, 2021
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
We need a space between the command (which ends with a container name) and the 2> or else the 2 is considered part of the command. E.g., ! /usr/bin/podman rm -f ceph-a9a8c7ee-5b72-11eb-8f93-001a4aab830c-mon.a2> /dev/null Fixes: 1bed46e Signed-off-by: Sage Weil <sage@newdream.net>
tchaikov
force-pushed
the
fix-cephadm-unit.run
branch
from
04cf32f
to
ce4743f
Compare
|
rebased against master. |
|
retest this please |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need a space between the command (which ends with a container name)
and the 2> or else the 2 is considered part of the command. E.g.,
! /usr/bin/podman rm -f ceph-a9a8c7ee-5b72-11eb-8f93-001a4aab830c-mon.a2> /dev/null
Fixes: 1bed46e
Signed-off-by: Sage Weil sage@newdream.net