spec: enable RWL/SSD caches #39049
Merged
spec: enable RWL/SSD caches #39049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dillaman Please have a look. |
3 tasks
dillaman
reviewed
Jan 25, 2021
ceph.spec.in
Outdated
| @@ -62,6 +62,8 @@ | |||
| %endif | |||
| %bcond_with seastar | |||
| %bcond_with jaeger | |||
| %bcond_with rbd_rwl | |||
There was a problem hiding this comment.
I know that (historically) the cmake option is just RBD_RWL, but might want to be more specific that it's a cache here for clarity.
Suggested change
| %bcond_with rbd_rwl | |
| %bcond_with rbd_rwl_cache |
There was a problem hiding this comment.
Updated, and thank you.
Signed-off-by: Li, Xiaoyan <xiaoyan.li@intel.com>
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Li, Xiaoyan xiaoyan.li@intel.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox