ceph.spec.in: fix handling of /var/run/ceph

[ktdreyer]

We want the RPM to install this. %ghost won't actually install it.

The purpose of this change is 1) simplicity and 2) gain the ability to automatically the permissions of the directory once Ceph gains unprivileged user support.

CC'ing @BRANTO1 for review.

[loic-bot]

SUCCESS: the output of run-make-check.sh on centos-7 for a1cff47 is http://paste2.org/PXnYpf56

Sent from GH.

[dalgaaf]

about the commit message: "...gain the ability to automatically the permissions ..." there seems to be a word missing (e.g. "... automatically set the permissions ...")

[ktdreyer]

Great catch, thanks. I've changed "automatically the permissions" to "automatically set the permissions".

[loic-bot]

SUCCESS: the output of run-make-check.sh on centos-7 for ba836ef is http://paste2.org/c0w7yDfU

Sent from GH.

[loic-bot]

SUCCESS: the output of run-make-check.sh on centos-7 for f00b84e is http://paste2.org/NhzZmULe

Sent from GH.

[dalgaaf]

Still not sure if this is the right way to do it. It's for example handled differently in openSUSE: https://en.opensuse.org/openSUSE:Systemd_packaging_guidelines#Creating_files_.2F_subdirectories_in_.2Fvar.2Frun_and_.2Frun

The SUSE Ceph package still uses in the %install dir:

%if 0%{?suse_version} >= 1310
%{__install} -d -m 0755 %{buildroot}/%{_tmpfilesdir}
%{__install} -m 0644 %{SOURCE3} %{buildroot}/%{_tmpfilesdir}/%{name}.conf
%else
mkdir -p $RPM_BUILD_ROOT%{_localstatedir}/run/ceph/
%endif

and in %files:

%if 0%{?suse_version} < 1310
%ghost %dir %{_localstatedir}/run/ceph/
%else
%dir %{_tmpfilesdir}/
%{_tmpfilesdir}/%{name}.conf
%endif

https://build.opensuse.org/package/view_file/filesystems:ceph/ceph/ceph.spec?expand=1

[ktdreyer]

Thanks for the links. I see now that I did not catch up with the latest information regarding systemd here. /etc/tmpfiles.d is probably the correct way to handle /var/run/ceph creation on modern systems that have systemd: http://www.freedesktop.org/software/systemd/man/tmpfiles.d.html

On older systems that don't have systemd (ie. RHEL 6), /var/run is not tmpfs, so I think we should still list the /var/run/ceph directory in %files, and remove the %ghost directive there.

@dalgaaf , how does that sound?

[dalgaaf]

I still wonder what the actual problem with the %ghost directive is. Did you check how other daemons handle the /var/run/$name in their spec files unter RHEL6 ?

[ktdreyer]

The problem with %ghost is that RPM doesn't make the /var/run/ceph directory writable by non-root users. This causes a problem for RGW, which runs as Apache by default (on non-Ubuntu). For the RGW problem, see http://tracker.ceph.com/issues/9001

So the immediate issue is for RGW, and from what Sage has said, there's also work in progress to make Ceph itself run as a non-root user too.

Since we want Ceph (and RGW) to eventually stop running as root, it makes sense for us to stop using %ghost on the /var/run/foo locations so that they can be made writable by non-root users.

Regarding your question of how other daemons do this, I checked the mysql package on RHEL 6, and it has the following in %files:

%attr(0755,mysql,mysql) %dir /var/run/mysqld

There's no %ghost there. We'd want to implement the same thing for Ceph on RHEL 6.

On RHEL 7, the mariadb package has Source10: mariadb.tmpfiles.d that's installed as %{_tmpfilesdir}/%{name}.conf. It also specifies /var/run locations in %files as well:

%attr(0755,mysql,mysql) %dir %{_localstatedir}/run/mariadb
%attr(0755,mysql,mysql) %dir %{_localstatedir}/lib/mysql

If this sounds good to you, I can re-work this pull request to include the tmpfiles.d snippet on distros with systemd in addition to removing the %ghost directive.

[dalgaaf]

I guess for now we can leave systemd out of the picture, we don't even package systemd atm to rpm. I take a separate look into it, we have to check which Fedora/SUSE products already use systemd.

Go ahead with the patch, but may use %attr(0755,root,root) %dir %{_localstatedir}/run/ceph. I will merge it then.

[ktdreyer]

Thanks Danny! new patch coming up.

[loic-bot]

SUCCESS: the output of run-make-check.sh on centos-7 for 110d87e is http://paste2.org/DXw7jzH4

Sent from GH.

[ktdreyer]

welp, this broke master. The fix is in #4181