mgr/dashboard: test prometheus rules through promtool #39246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaSharma14
requested review from
a team,
avanthakkar,
callithea,
nizamial09,
votdev,
s0nea,
alfonsomthd and
epuertat
and removed request for
a team
|
@aaSharma14 I think that in order to complete this work it is needed a script like (just an example): https://github.com/ceph/ceph/blob/master/src/pybind/mgr/dashboard/run-frontend-e2e-tests.sh so that test you mention in the description can be run (and even create a jenkins job in case we find it necessary). |
Thanks @alfonsomthd ..will work on the script. |
aaSharma14
force-pushed
the
fix-45415-master
branch
from
74794e3
to
668ca36
Compare
aaSharma14
changed the title
p-se
reviewed
Feb 16, 2021
p-se
reviewed
Feb 17, 2021
There was a problem hiding this comment.
This is a great addition. It seems to work very good. Thanks for that!
If you could rename the commit message to not include "[WIP]" anymore, I'd be glad to approve.
Additionally, but also optionally, it'd be good to have consistent indentation in the test_alerts.yml file.
p-se
reviewed
Feb 17, 2021
avanthakkar
approved these changes
Feb 17, 2021
aaSharma14
force-pushed
the
fix-45415-master
branch
from
668ca36
to
6ab6cb8
Compare
Thanks @p-se . I have added consistent indentation in the test_alerts.yml file and changed the commit message as well. |
|
jenkins test make check |
p-se
approved these changes
Feb 18, 2021
This PR intends to add unit testing for prometheus rules using promtool. To run the tests run 'run-promtool-unittests.sh' file. Fixes: https://tracker.ceph.com/issues/45415 Signed-off-by: Aashish Sharma <aasharma@redhat.com>
aaSharma14
force-pushed
the
fix-45415-master
branch
from
7f4a54c
to
53a5816
Compare
This was referenced Mar 10, 2021
|
I struck the same issue as rishabh-d-dave. Why are we installing docker on systems where podman already exists? The reason I run podman is so I don't have to install/run docker and all that entails. |
1 task
tchaikov
added a commit
to tchaikov/ceph
that referenced
this pull request
Mar 19, 2021
before this change, we use docker for running promtools offered by a docker image, but this is not efficient, and quite a few developers do not want to use docker for running "make check". this change was introduced by ceph#39246, the reason was that, in Ceph's CI process, we are using Ubuntu/Bionic for running "make check" jobs, but prometheus packaged by Bionic does not offer the "test rules" command. so, to address problem, we are using "dnanexus/promtool:2.9.2" docker image for verifying monitoring/prometheus/alerts/test_alerts.yml. after this change, we use prometheus packaged by debian derivatives instead of pulling a docker image. * debian/control: add prometheus as a "make check" dependency * install-deps.sh: partially revert 53a5816, as we don't need to pull docker or start docker service for using promtool anymore. * cmake: check if promtool is capable of running "test rules" command, bail out if it is not. see also: https://tracker.ceph.com/issues/49653 Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
added a commit
to tchaikov/ceph
that referenced
this pull request
Mar 19, 2021
before this change, we use docker for running promtools offered by a docker image, but this is not efficient, and quite a few developers do not want to use docker for running "make check". this change was introduced by ceph#39246, the reason was that, in Ceph's CI process, we are using Ubuntu/Bionic for running "make check" jobs, but prometheus packaged by Bionic does not offer the "test rules" command. so, to address problem, we are using "dnanexus/promtool:2.9.2" docker image for verifying monitoring/prometheus/alerts/test_alerts.yml. after this change, we use prometheus packaged by debian derivatives instead of pulling a docker image. * debian/control: add prometheus as a "make check" dependency * install-deps.sh: partially revert 53a5816, as we don't need to pull docker or start docker service for using promtool anymore. * cmake: check if promtool is capable of running "test rules" command, bail out if it is not. see also: https://tracker.ceph.com/issues/49653 Signed-off-by: Kefu Chai <kchai@redhat.com>
aaSharma14
pushed a commit
to aaSharma14/ceph
that referenced
this pull request
Apr 16, 2021
before this change, we use docker for running promtools offered by a docker image, but this is not efficient, and quite a few developers do not want to use docker for running "make check". this change was introduced by ceph#39246, the reason was that, in Ceph's CI process, we are using Ubuntu/Bionic for running "make check" jobs, but prometheus packaged by Bionic does not offer the "test rules" command. so, to address problem, we are using "dnanexus/promtool:2.9.2" docker image for verifying monitoring/prometheus/alerts/test_alerts.yml. after this change, we use prometheus packaged by debian derivatives instead of pulling a docker image. * debian/control: add prometheus as a "make check" dependency * install-deps.sh: partially revert 53a5816, as we don't need to pull docker or start docker service for using promtool anymore. * cmake: check if promtool is capable of running "test rules" command, bail out if it is not. see also: https://tracker.ceph.com/issues/49653 Signed-off-by: Kefu Chai <kchai@redhat.com> Conflicts: debian/control install-deps.sh src/test/CMakeLists.txt
aaSharma14
pushed a commit
to aaSharma14/ceph
that referenced
this pull request
Apr 16, 2021
before this change, we use docker for running promtools offered by a docker image, but this is not efficient, and quite a few developers do not want to use docker for running "make check". this change was introduced by ceph#39246, the reason was that, in Ceph's CI process, we are using Ubuntu/Bionic for running "make check" jobs, but prometheus packaged by Bionic does not offer the "test rules" command. so, to address problem, we are using "dnanexus/promtool:2.9.2" docker image for verifying monitoring/prometheus/alerts/test_alerts.yml. after this change, we use prometheus packaged by debian derivatives instead of pulling a docker image. * debian/control: add prometheus as a "make check" dependency * install-deps.sh: partially revert 53a5816, as we don't need to pull docker or start docker service for using promtool anymore. * cmake: check if promtool is capable of running "test rules" command, bail out if it is not. see also: https://tracker.ceph.com/issues/49653 Signed-off-by: Kefu Chai <kchai@redhat.com> Conflicts: debian/control src/test/CMakeLists.txt
aaSharma14
pushed a commit
to aaSharma14/ceph
that referenced
this pull request
Apr 16, 2021
before this change, we use docker for running promtools offered by a docker image, but this is not efficient, and quite a few developers do not want to use docker for running "make check". this change was introduced by ceph#39246, the reason was that, in Ceph's CI process, we are using Ubuntu/Bionic for running "make check" jobs, but prometheus packaged by Bionic does not offer the "test rules" command. so, to address problem, we are using "dnanexus/promtool:2.9.2" docker image for verifying monitoring/prometheus/alerts/test_alerts.yml. after this change, we use prometheus packaged by debian derivatives instead of pulling a docker image. * debian/control: add prometheus as a "make check" dependency * install-deps.sh: partially revert 53a5816, as we don't need to pull docker or start docker service for using promtool anymore. * cmake: check if promtool is capable of running "test rules" command, bail out if it is not. see also: https://tracker.ceph.com/issues/49653 Signed-off-by: Kefu Chai <kchai@redhat.com> Conflicts: debian/control src/test/CMakeLists.txt
aaSharma14
pushed a commit
to aaSharma14/ceph
that referenced
this pull request
Apr 20, 2021
before this change, we use docker for running promtools offered by a docker image, but this is not efficient, and quite a few developers do not want to use docker for running "make check". this change was introduced by ceph#39246, the reason was that, in Ceph's CI process, we are using Ubuntu/Bionic for running "make check" jobs, but prometheus packaged by Bionic does not offer the "test rules" command. so, to address problem, we are using "dnanexus/promtool:2.9.2" docker image for verifying monitoring/prometheus/alerts/test_alerts.yml. after this change, we use prometheus packaged by debian derivatives instead of pulling a docker image. * debian/control: add prometheus as a "make check" dependency * install-deps.sh: partially revert 53a5816, as we don't need to pull docker or start docker service for using promtool anymore. * cmake: check if promtool is capable of running "test rules" command, bail out if it is not. see also: https://tracker.ceph.com/issues/49653 Signed-off-by: Kefu Chai <kchai@redhat.com>
aaSharma14
pushed a commit
to aaSharma14/ceph
that referenced
this pull request
Apr 20, 2021
before this change, we use docker for running promtools offered by a docker image, but this is not efficient, and quite a few developers do not want to use docker for running "make check". this change was introduced by ceph#39246, the reason was that, in Ceph's CI process, we are using Ubuntu/Bionic for running "make check" jobs, but prometheus packaged by Bionic does not offer the "test rules" command. so, to address problem, we are using "dnanexus/promtool:2.9.2" docker image for verifying monitoring/prometheus/alerts/test_alerts.yml. after this change, we use prometheus packaged by debian derivatives instead of pulling a docker image. * debian/control: add prometheus as a "make check" dependency * install-deps.sh: partially revert 53a5816, as we don't need to pull docker or start docker service for using promtool anymore. * cmake: check if promtool is capable of running "test rules" command, bail out if it is not. see also: https://tracker.ceph.com/issues/49653 Signed-off-by: Kefu Chai <kchai@redhat.com>
aaSharma14
pushed a commit
to aaSharma14/ceph
that referenced
this pull request
Apr 20, 2021
before this change, we use docker for running promtools offered by a docker image, but this is not efficient, and quite a few developers do not want to use docker for running "make check". this change was introduced by ceph#39246, the reason was that, in Ceph's CI process, we are using Ubuntu/Bionic for running "make check" jobs, but prometheus packaged by Bionic does not offer the "test rules" command. so, to address problem, we are using "dnanexus/promtool:2.9.2" docker image for verifying monitoring/prometheus/alerts/test_alerts.yml. after this change, we use prometheus packaged by debian derivatives instead of pulling a docker image. * debian/control: add prometheus as a "make check" dependency * install-deps.sh: partially revert 53a5816, as we don't need to pull docker or start docker service for using promtool anymore. * cmake: check if promtool is capable of running "test rules" command, bail out if it is not. see also: https://tracker.ceph.com/issues/49653 Signed-off-by: Kefu Chai <kchai@redhat.com>
aaSharma14
pushed a commit
to aaSharma14/ceph
that referenced
this pull request
Apr 20, 2021
before this change, we use docker for running promtools offered by a docker image, but this is not efficient, and quite a few developers do not want to use docker for running "make check". this change was introduced by ceph#39246, the reason was that, in Ceph's CI process, we are using Ubuntu/Bionic for running "make check" jobs, but prometheus packaged by Bionic does not offer the "test rules" command. so, to address problem, we are using "dnanexus/promtool:2.9.2" docker image for verifying monitoring/prometheus/alerts/test_alerts.yml. after this change, we use prometheus packaged by debian derivatives instead of pulling a docker image. * debian/control: add prometheus as a "make check" dependency * install-deps.sh: partially revert 53a5816, as we don't need to pull docker or start docker service for using promtool anymore. * cmake: check if promtool is capable of running "test rules" command, bail out if it is not. see also: https://tracker.ceph.com/issues/49653 Signed-off-by: Kefu Chai <kchai@redhat.com> Conflicts: debian/control src/test/CMakeLists.txt
aaSharma14
pushed a commit
to rhcs-dashboard/ceph
that referenced
this pull request
Apr 21, 2021
before this change, we use docker for running promtools offered by a docker image, but this is not efficient, and quite a few developers do not want to use docker for running "make check". this change was introduced by ceph#39246, the reason was that, in Ceph's CI process, we are using Ubuntu/Bionic for running "make check" jobs, but prometheus packaged by Bionic does not offer the "test rules" command. so, to address problem, we are using "dnanexus/promtool:2.9.2" docker image for verifying monitoring/prometheus/alerts/test_alerts.yml. after this change, we use prometheus packaged by debian derivatives instead of pulling a docker image. * debian/control: add prometheus as a "make check" dependency * install-deps.sh: partially revert 53a5816, as we don't need to pull docker or start docker service for using promtool anymore. * cmake: check if promtool is capable of running "test rules" command, bail out if it is not. see also: https://tracker.ceph.com/issues/49653 Signed-off-by: Kefu Chai <kchai@redhat.com>
aaSharma14
pushed a commit
to aaSharma14/ceph
that referenced
this pull request
Apr 21, 2021
before this change, we use docker for running promtools offered by a docker image, but this is not efficient, and quite a few developers do not want to use docker for running "make check". this change was introduced by ceph#39246, the reason was that, in Ceph's CI process, we are using Ubuntu/Bionic for running "make check" jobs, but prometheus packaged by Bionic does not offer the "test rules" command. so, to address problem, we are using "dnanexus/promtool:2.9.2" docker image for verifying monitoring/prometheus/alerts/test_alerts.yml. after this change, we use prometheus packaged by debian derivatives instead of pulling a docker image. * debian/control: add prometheus as a "make check" dependency * install-deps.sh: partially revert 53a5816, as we don't need to pull docker or start docker service for using promtool anymore. * cmake: check if promtool is capable of running "test rules" command, bail out if it is not. see also: https://tracker.ceph.com/issues/49653 Signed-off-by: Kefu Chai <kchai@redhat.com> Conflicts: debian/control src/test/CMakeLists.txt
aaSharma14
pushed a commit
to aaSharma14/ceph
that referenced
this pull request
Apr 21, 2021
before this change, we use docker for running promtools offered by a docker image, but this is not efficient, and quite a few developers do not want to use docker for running "make check". this change was introduced by ceph#39246, the reason was that, in Ceph's CI process, we are using Ubuntu/Bionic for running "make check" jobs, but prometheus packaged by Bionic does not offer the "test rules" command. so, to address problem, we are using "dnanexus/promtool:2.9.2" docker image for verifying monitoring/prometheus/alerts/test_alerts.yml. after this change, we use prometheus packaged by debian derivatives instead of pulling a docker image. * debian/control: add prometheus as a "make check" dependency * install-deps.sh: partially revert 53a5816, as we don't need to pull docker or start docker service for using promtool anymore. * cmake: check if promtool is capable of running "test rules" command, bail out if it is not. see also: https://tracker.ceph.com/issues/49653 Signed-off-by: Kefu Chai <kchai@redhat.com> Conflicts: debian/control src/test/CMakeLists.txt
aaSharma14
pushed a commit
to aaSharma14/ceph
that referenced
this pull request
Apr 21, 2021
before this change, we use docker for running promtools offered by a docker image, but this is not efficient, and quite a few developers do not want to use docker for running "make check". this change was introduced by ceph#39246, the reason was that, in Ceph's CI process, we are using Ubuntu/Bionic for running "make check" jobs, but prometheus packaged by Bionic does not offer the "test rules" command. so, to address problem, we are using "dnanexus/promtool:2.9.2" docker image for verifying monitoring/prometheus/alerts/test_alerts.yml. after this change, we use prometheus packaged by debian derivatives instead of pulling a docker image. * debian/control: add prometheus as a "make check" dependency * install-deps.sh: partially revert 53a5816, as we don't need to pull docker or start docker service for using promtool anymore. * cmake: check if promtool is capable of running "test rules" command, bail out if it is not. see also: https://tracker.ceph.com/issues/49653 Signed-off-by: Kefu Chai <kchai@redhat.com> Conflicts: debian/control src/test/CMakeLists.txt
aaSharma14
pushed a commit
to aaSharma14/ceph
that referenced
this pull request
Apr 21, 2021
before this change, we use docker for running promtools offered by a docker image, but this is not efficient, and quite a few developers do not want to use docker for running "make check". this change was introduced by ceph#39246, the reason was that, in Ceph's CI process, we are using Ubuntu/Bionic for running "make check" jobs, but prometheus packaged by Bionic does not offer the "test rules" command. so, to address problem, we are using "dnanexus/promtool:2.9.2" docker image for verifying monitoring/prometheus/alerts/test_alerts.yml. after this change, we use prometheus packaged by debian derivatives instead of pulling a docker image. * debian/control: add prometheus as a "make check" dependency * install-deps.sh: partially revert 53a5816, as we don't need to pull docker or start docker service for using promtool anymore. * cmake: check if promtool is capable of running "test rules" command, bail out if it is not. see also: https://tracker.ceph.com/issues/49653 Signed-off-by: Kefu Chai <kchai@redhat.com>
aaSharma14
pushed a commit
to aaSharma14/ceph
that referenced
this pull request
Apr 21, 2021
before this change, we use docker for running promtools offered by a docker image, but this is not efficient, and quite a few developers do not want to use docker for running "make check". this change was introduced by ceph#39246, the reason was that, in Ceph's CI process, we are using Ubuntu/Bionic for running "make check" jobs, but prometheus packaged by Bionic does not offer the "test rules" command. so, to address problem, we are using "dnanexus/promtool:2.9.2" docker image for verifying monitoring/prometheus/alerts/test_alerts.yml. after this change, we use prometheus packaged by debian derivatives instead of pulling a docker image. * debian/control: add prometheus as a "make check" dependency * install-deps.sh: partially revert 53a5816, as we don't need to pull docker or start docker service for using promtool anymore. * cmake: check if promtool is capable of running "test rules" command, bail out if it is not. see also: https://tracker.ceph.com/issues/49653 Signed-off-by: Kefu Chai <kchai@redhat.com> Conflicts: debian/control src/test/CMakeLists.txt
aaSharma14
pushed a commit
to rhcs-dashboard/ceph
that referenced
this pull request
Apr 21, 2021
before this change, we use docker for running promtools offered by a docker image, but this is not efficient, and quite a few developers do not want to use docker for running "make check". this change was introduced by ceph#39246, the reason was that, in Ceph's CI process, we are using Ubuntu/Bionic for running "make check" jobs, but prometheus packaged by Bionic does not offer the "test rules" command. so, to address problem, we are using "dnanexus/promtool:2.9.2" docker image for verifying monitoring/prometheus/alerts/test_alerts.yml. after this change, we use prometheus packaged by debian derivatives instead of pulling a docker image. * debian/control: add prometheus as a "make check" dependency * install-deps.sh: partially revert 53a5816, as we don't need to pull docker or start docker service for using promtool anymore. * cmake: check if promtool is capable of running "test rules" command, bail out if it is not. see also: https://tracker.ceph.com/issues/49653 Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit f381aa8)
aaSharma14
pushed a commit
to aaSharma14/ceph
that referenced
this pull request
Apr 23, 2021
before this change, we use docker for running promtools offered by a docker image, but this is not efficient, and quite a few developers do not want to use docker for running "make check". this change was introduced by ceph#39246, the reason was that, in Ceph's CI process, we are using Ubuntu/Bionic for running "make check" jobs, but prometheus packaged by Bionic does not offer the "test rules" command. so, to address problem, we are using "dnanexus/promtool:2.9.2" docker image for verifying monitoring/prometheus/alerts/test_alerts.yml. after this change, we use prometheus packaged by debian derivatives instead of pulling a docker image. * debian/control: add prometheus as a "make check" dependency * install-deps.sh: partially revert 53a5816, as we don't need to pull docker or start docker service for using promtool anymore. * cmake: check if promtool is capable of running "test rules" command, bail out if it is not. see also: https://tracker.ceph.com/issues/49653 Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit f381aa8) Conflicts: debian/control (python-cherrypy3 conficts with python-cherrypy3 | python3-cherrypy3 in nautilus) install-deps.sh (preload_wheels_for_tox method not in nautilus so removed that) src/test/CMakeLists.txt (ceph#561-594 new changes overrid these lines, merged correctly now)
aaSharma14
pushed a commit
to aaSharma14/ceph
that referenced
this pull request
Apr 23, 2021
before this change, we use docker for running promtools offered by a docker image, but this is not efficient, and quite a few developers do not want to use docker for running "make check". this change was introduced by ceph#39246, the reason was that, in Ceph's CI process, we are using Ubuntu/Bionic for running "make check" jobs, but prometheus packaged by Bionic does not offer the "test rules" command. so, to address problem, we are using "dnanexus/promtool:2.9.2" docker image for verifying monitoring/prometheus/alerts/test_alerts.yml. after this change, we use prometheus packaged by debian derivatives instead of pulling a docker image. * debian/control: add prometheus as a "make check" dependency * install-deps.sh: partially revert 53a5816, as we don't need to pull docker or start docker service for using promtool anymore. * cmake: check if promtool is capable of running "test rules" command, bail out if it is not. see also: https://tracker.ceph.com/issues/49653 Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit f381aa8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to add unit testing for prometheus/alertmanager rules using promtool. To run the tests- With ceph_default_alerts.yml in the same directory, run 'promtool test rules test.yml'
Fixes: https://tracker.ceph.com/issues/45415
Signed-off-by: Aashish Sharma aasharma@redhat.com
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox