New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake: partial revert of BOOST_USE_VALGRIND when ALLOCATOR=libc #39263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the WITH_SYSTEM_BOOST binaries are not built with BOOST_USE_VALGRIND, so it probably isn't safe to define for the headers only this flag is needed for teuthology testing, and the shaman builds use WITH_SYSTEM_BOOST=OFF. so the better fix is to enable WITH_BOOST_VALGRIND so BuildBoost.cmake will build the libraries with valgrind support and add -DBOOST_USE_VALGRIND to the necessary targets this change was merged in ceph/ceph-build#1736 Fixes: https://tracker.ceph.com/issues/48963 Signed-off-by: Casey Bodley <cbodley@redhat.com>
uh oh, all tests in https://pulpito.ceph.com/cbodley-2021-02-03_16:14:08-rgw:verify-wip-48963-distro-basic-gibba/ (built with WITH_BOOST_VALGRIND) failed with this segfault:
seeing if i can reproduce it myself |
the segfault was due to radosgw's cmake not forwarding the BOOST_USE_VALGRIND definition from boost::context fixed in #39279 |
yuvalif
approved these changes
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the WITH_SYSTEM_BOOST binaries are not built with BOOST_USE_VALGRIND, so it probably isn't safe to define for the headers only
this flag is needed for teuthology testing, and the shaman builds use WITH_SYSTEM_BOOST=OFF. so the better fix is to enable WITH_BOOST_VALGRIND so BuildBoost.cmake will build the libraries with valgrind support and add -DBOOST_USE_VALGRIND to the necessary targets
this change was merged in ceph/ceph-build#1736
Fixes: https://tracker.ceph.com/issues/48963
Checklist
Show available Jenkins commands
jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox