Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgr/cephadm: cleanup daemon keyring on failed daemon deploy #39266

Merged
merged 1 commit into from Feb 8, 2021
Merged

mgr/cephadm: cleanup daemon keyring on failed daemon deploy #39266

merged 1 commit into from Feb 8, 2021

Conversation

sebastian-philipp
Copy link
Contributor

Fixes: https://tracker.ceph.com/issues/48164
Signed-off-by: Sebastian Wagner sebastian.wagner@suse.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@sebastian-philipp
mgr/cephadm: cleanup daemon keyring on failed daemon deploy
f200cb2 
Fixes: https://tracker.ceph.com/issues/48164
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
@sebastian-philipp sebastian-philipp requested a review from a team as a code owner February 3, 2021 15:24
jmolmo
jmolmo approved these changes Feb 4, 2021
View reviewed changes
Copy link
Member

@jmolmo jmolmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebastian-philipp
Copy link
Contributor Author

https://pulpito.ceph.com/swagner-2021-02-04_11:24:34-rados:cephadm-wip-swagner4-testing-2021-02-03-1650-distro-basic-smithi/
https://pulpito.ceph.com/swagner-2021-02-05_09:14:24-rados:cephadm-wip-swagner4-testing-2021-02-03-1650-distro-basic-smithi/

@sebastian-philipp
Copy link
Contributor Author

jenkins test make check

@sebastian-philipp
Copy link
Contributor Author

jenkins test make check

@sebastian-philipp sebastian-philipp merged commit 44b912b into ceph:master Feb 8, 2021
@sebastian-philipp sebastian-philipp mentioned this pull request Feb 9, 2021
Merged
@jmolmo jmolmo mentioned this pull request Feb 19, 2021
Closed
@sebastian-philipp sebastian-philipp mentioned this pull request Feb 23, 2021
Merged
3 tasks
@sebastian-philipp
Copy link
Contributor Author

regression: https://tracker.ceph.com/issues/49872

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmolmo jmolmo jmolmo approved these changes

Assignees
No one assigned
Labels
cephadm pybind ready-to-merge
Projects
None yet
Milestone
No milestone
2 participants
@sebastian-philipp @jmolmo