Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qa/tasks/mgr/test_progress.py: wait longer for event to pop up #39278

Closed
wants to merge 1 commit into from

Conversation

kamoltat
Copy link
Member

@kamoltat kamoltat commented Feb 3, 2021

In test_turn_off_module() increase timeout from 10 seconds
to 40 seconds for event to pop up after progress module is
turned back on

Fixes: https://tracker.ceph.com/issues/48841

Signed-off-by: Kamoltat ksirivad@redhat.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@kamoltat
Copy link
Member Author

kamoltat commented Feb 4, 2021

https://pulpito.ceph.com/ksirivad-2021-02-04_05:50:58-rados:mgr-wip-fix-test-turn-off-module-distro-basic-smithi/

2021-02-04T06:41:43.210 INFO:tasks.cephfs_test_runner:======================================================================
2021-02-04T06:41:43.211 INFO:tasks.cephfs_test_runner:FAIL: test_turn_off_module (tasks.mgr.test_progress.TestProgress)
2021-02-04T06:41:43.211 INFO:tasks.cephfs_test_runner:----------------------------------------------------------------------
2021-02-04T06:41:43.211 INFO:tasks.cephfs_test_runner:Traceback (most recent call last):
2021-02-04T06:41:43.212 INFO:tasks.cephfs_test_runner: File "/home/teuthworker/src/github.com_ceph_ceph-c_70dd718db7e51c528c9a7fdbfa76ac164ac8b80e/qa/tasks/mgr/test_progress.py", line 349, in test_turn_off_module
2021-02-04T06:41:43.213 INFO:tasks.cephfs_test_runner: self.assertTrue(self._is_quiet())
2021-02-04T06:41:43.213 INFO:tasks.cephfs_test_runner:AssertionError: False is not true
2021-02-04T06:41:43.213 INFO:tasks.cephfs_test_runner:
2021-02-04T06:41:43.214 INFO:tasks.cephfs_test_runner:----------------------------------------------------------------------
2021-02-04T06:41:43.214 INFO:tasks.cephfs_test_runner:Ran 5 tests in 383.798s
2021-02-04T06:41:43.214 INFO:tasks.cephfs_test_runner:
2021-02-04T06:41:43.215 INFO:tasks.cephfs_test_runner:FAILED (failures=1)
2021-02-04T06:41:43.215 INFO:tasks.cephfs_test_runner:
2021-02-04T06:41:43.216 INFO:tasks.cephfs_test_runner:======================================================================

self.wait_until_true(lambda: self._is_complete(ev1['id']),
timeout=self.RECOVERY_PERIOD)

self.assertEqual(self._osd_in_out_events_count(), 0)
Copy link
Member Author

@kamoltat kamoltat Feb 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use _osd_in_out_events_count() instead of _is_quiet() since the global event can occur a bit later and finish later than osd in/out events

@tchaikov
Copy link
Contributor

tchaikov commented Feb 4, 2021

@kamoltat I think the tests should be relatively self-contained. we should not rely on the side-effects or the order in which they are performed for testing. ideally, I'd suggest do the cleanup when each test exits.

@jdurgin
Copy link
Member

jdurgin commented Feb 4, 2021

agreed with @tchaikov, the test order should not matter, each test should cleanup after itself

@neha-ojha neha-ojha added the DNM label Feb 11, 2021
@kamoltat kamoltat changed the title qa/tasks/mgr/test_progress.py: switch order of test functions qa/tasks/mgr/test_progress.py: wait longer for event to pop up Feb 15, 2021
In test_turn_off_module() increase timeout from 10 seconds
to 40 seconds for event to pop up after progress module is
turned back on

Fixes: https://tracker.ceph.com/issues/48841

Signed-off-by: Kamoltat <ksirivad@redhat.com>
@kamoltat
Copy link
Member Author

might not need this PR since the failures are caused by https://tracker.ceph.com/issues/49138

@stale
Copy link

stale bot commented Jul 21, 2021

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@stale stale bot added the stale label Jul 21, 2021
@neha-ojha
Copy link
Member

@kamoltat we've stopped seeing https://tracker.ceph.com/issues/48841 in recent teuthology runs, has this bug been addressed by another change or is the test racy?

@stale stale bot removed the stale label Jul 21, 2021
@github-actions
Copy link

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@kamoltat
Copy link
Member Author

@kamoltat we've stopped seeing https://tracker.ceph.com/issues/48841 in recent teuthology runs, has this bug been addressed by another change or is the test racy?

@neha-ojha Yes so #41907 think fixed it will close this and update tracker

@kamoltat kamoltat closed this Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants