-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qa/tasks/mgr/test_progress.py: wait longer for event to pop up #39278
Conversation
2021-02-04T06:41:43.210 INFO:tasks.cephfs_test_runner:====================================================================== |
70dd718
to
5c86881
Compare
qa/tasks/mgr/test_progress.py
Outdated
self.wait_until_true(lambda: self._is_complete(ev1['id']), | ||
timeout=self.RECOVERY_PERIOD) | ||
|
||
self.assertEqual(self._osd_in_out_events_count(), 0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use _osd_in_out_events_count() instead of _is_quiet() since the global event can occur a bit later and finish later than osd in/out events
@kamoltat I think the tests should be relatively self-contained. we should not rely on the side-effects or the order in which they are performed for testing. ideally, I'd suggest do the cleanup when each test exits. |
agreed with @tchaikov, the test order should not matter, each test should cleanup after itself |
5c86881
to
8e3ffa3
Compare
In test_turn_off_module() increase timeout from 10 seconds to 40 seconds for event to pop up after progress module is turned back on Fixes: https://tracker.ceph.com/issues/48841 Signed-off-by: Kamoltat <ksirivad@redhat.com>
8e3ffa3
to
3078c77
Compare
might not need this PR since the failures are caused by https://tracker.ceph.com/issues/49138 |
This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days. |
@kamoltat we've stopped seeing https://tracker.ceph.com/issues/48841 in recent teuthology runs, has this bug been addressed by another change or is the test racy? |
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
@neha-ojha Yes so #41907 think fixed it will close this and update tracker |
In test_turn_off_module() increase timeout from 10 seconds
to 40 seconds for event to pop up after progress module is
turned back on
Fixes: https://tracker.ceph.com/issues/48841
Signed-off-by: Kamoltat ksirivad@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox