Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

osdc,librados: set FULL_TRY flag by ioctx, not globally on the objecter #39282

Merged
merged 3 commits into from Feb 15, 2021
Merged

osdc,librados: set FULL_TRY flag by ioctx, not globally on the objecter #39282

merged 3 commits into from Feb 15, 2021

Conversation

liewegas
Copy link
Member

@liewegas liewegas commented Feb 3, 2021

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@liewegas
librados/IoCtxImpl: pass extra_op_flags everywhere
6856483 
Unused, so far...

Signed-off-by: Sage Weil <sage@newdream.net>
@liewegas
librados: set FULL_TRY flag on ioctx, not objecter
a8bed67 
Signed-off-by: Sage Weil <sage@newdream.net>
@liewegas
osdc/Objecter: remove pool_full_try interface
e468fc0 
Signed-off-by: Sage Weil <sage@newdream.net>
@github-actions github-actions bot added the core label Feb 3, 2021
dillaman
dillaman approved these changes Feb 3, 2021
View reviewed changes
Copy link

@dillaman dillaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm -- thx

@dillaman
Copy link

dillaman commented Feb 3, 2021

... might need to change neorados as well since previously it was inheriting it from the Objector

@liewegas liewegas merged commit 94448f9 into ceph:master Feb 15, 2021
@liewegas liewegas mentioned this pull request Feb 15, 2021
Merged
@idryomov idryomov mentioned this pull request Sep 17, 2021
Merged
@liewegas liewegas deleted the librados-full-try-by-ioctx branch September 17, 2021 15:37
@idryomov idryomov mentioned this pull request Oct 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dillaman dillaman dillaman approved these changes

Assignees
No one assigned
Labels
core needs-qa wip-sage2-testing
Projects
None yet
Milestone
No milestone
3 participants
@liewegas @dillaman @tchaikov