Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pybind/mgr/balancer: add type annotations #39295

Merged
merged 6 commits into from Feb 8, 2021
Merged

pybind/mgr/balancer: add type annotations #39295

merged 6 commits into from Feb 8, 2021

Conversation

tchaikov
Copy link
Contributor

@tchaikov tchaikov commented Feb 4, 2021

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

sebastian-philipp
sebastian-philipp approved these changes Feb 4, 2021
View reviewed changes
Copy link
Contributor

@sebastian-philipp sebastian-philipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tchaikov
Copy link
Contributor Author

tchaikov commented Feb 4, 2021

jenkins test api

xiexingguo
xiexingguo approved these changes Feb 5, 2021
View reviewed changes
Copy link
Member

@xiexingguo xiexingguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it

@tchaikov
Copy link
Contributor Author

tchaikov commented Feb 5, 2021

changelog

  • assign an empty list to allow set if "pool_ids" is empty. otherwise we'd have [""], and "" cannot be converted to an int.

@tchaikov
Copy link
Contributor Author

tchaikov commented Feb 6, 2021

changelog

  • corrected the command prefix of balancer eval.

@tchaikov tchaikov force-pushed the wip-mgr-balancer-ann branch 2 times, most recently from 1118bc2 to 289bd3e Compare February 6, 2021 15:33
@tchaikov
pybind/mgr/balancer: define commands using CLICommand
46f00b3 
Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov
pybind/mgr/balancer: add type annotations
376939d 
Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov
pybind/mgr/balancer: define options using Option
af3f49d 
Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov
pybind/mgr/alerts: flake8 cleanups
51ee392 
Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov
pybind/mgr/balancer: define Plan.{dump,show}()
0d48b03 
as they are called by the commands

Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov
pybind/mgr/balancer: flake8 cleanups
6448226 
Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov
Copy link
Contributor Author

tchaikov commented Feb 7, 2021

changelog

  • change mode.name to mode.value.

@tchaikov
Copy link
Contributor Author

tchaikov commented Feb 8, 2021

reran the failed tests on master

e2e failures tracked by

@tchaikov tchaikov merged commit 385db1c into ceph:master Feb 8, 2021
@tchaikov tchaikov deleted the wip-mgr-balancer-ann branch February 8, 2021 03:52
@cfsnyder cfsnyder mentioned this pull request Nov 16, 2021
Merged
@cfsnyder cfsnyder mentioned this pull request Nov 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastian-philipp sebastian-philipp sebastian-philipp approved these changes

@xiexingguo xiexingguo xiexingguo approved these changes

@liewegas liewegas Awaiting requested review from liewegas

Assignees
No one assigned
Labels
mgr needs-qa pybind wip-kefu-testing
Projects
None yet
Milestone
No milestone
3 participants
@tchaikov @sebastian-philipp @xiexingguo