Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nautilus: librados, tests: allow to list objects with the NUL character in names #39324

Merged
merged 4 commits into from Mar 1, 2021
Merged

nautilus: librados, tests: allow to list objects with the NUL character in names #39324

merged 4 commits into from Mar 1, 2021

Conversation

rzarzynski
Copy link
Contributor

In contrast to the counterpart for master (PR #39322), this branch lacks the commit for pybind.

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@rzarzynski
librados: introduce rados_nobjects_list_next2().
ba6dba6 
It's needed to properly list an object with the NUL
character in the name. Such names can appear mostly
as a consequence of bugs in clients.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
(cherry picked from commit 9d268b0)

Conflicts:
	src/librados/librados_c.cc (nautilus lacks
	the LIBRADOS_C_API_DEFAULT_F macro which is
	present in master; customized the changes to
	to fit nautilus)
@rzarzynski
test: add unit test for rados_nobjects_list_next2().
4684acd 
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
(cherry picked from commit 8965506)
@rzarzynski
librados: NObjectIteratorImpl takes care about NUL in obj name.
8b5099e 
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
(cherry picked from commit 22bb149)
@rzarzynski
tools: switch scratch tool to use rados_nobjects_list_next2().
b71bb4d 
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
(cherry picked from commit 05dca8a)
@rzarzynski rzarzynski force-pushed the wip-librados-nul-objname-nautilus branch from df0da35 to b71bb4d Compare February 5, 2021 19:33
@rzarzynski rzarzynski mentioned this pull request Feb 5, 2021
Merged
3 tasks
@smithfarm smithfarm added this to the nautilus milestone Feb 25, 2021
@yuriw yuriw merged commit ead1cd5 into ceph:nautilus Mar 1, 2021
@rzarzynski rzarzynski mentioned this pull request Mar 9, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivancich ivancich ivancich approved these changes

@tchaikov tchaikov Awaiting requested review from tchaikov

@jdurgin jdurgin Awaiting requested review from jdurgin

Assignees
No one assigned
Labels
core nautilus-batch-1 nautilus point releases needs-qa tests wip-yuri5-testing
Projects
None yet
Milestone
nautilus
4 participants
@rzarzynski @ivancich @yuriw @smithfarm