-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: ceph_test_rados_api_watch_notify: Allow for reconnect #39601
tests: ceph_test_rados_api_watch_notify: Allow for reconnect #39601
Conversation
An injected socket failure may cause rados_watch_check() to return ENOENT instead of the expected ENOTCONN. Fixes: https://tracker.ceph.com/issues/47719 Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
jenkins test make check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your analysis in https://tracker.ceph.com/issues/47719#note-9 makes sense to me, we could further verify your theory by removing failure injection from these tests and see if we hit the issue.
make check failure tracked in https://tracker.ceph.com/issues/49426 |
jenkins test make check |
I ran 50 tests with msgr-failures and 50 without. With msgr-failures I saw multiple failures (all have trackers) including three instances of this issue. Without msgr-failures I still saw multiple failures but I saw no instances of this specific issue. |
jenkins test make check |
1 similar comment
jenkins test make check |
An injected socket failure may cause rados_watch_check() to return
ENOENT instead of the expected ENOTCONN.
Fixes: https://tracker.ceph.com/issues/47719
Signed-off-by: Brad Hubbard bhubbard@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox