crush/CrushWrapper: update shadow trees on update_item() #39629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
insert_item() already does this, but update_item did not. Fixes: https://tracker.ceph.com/issues/48065 Signed-off-by: Sage Weil <sage@newdream.net>
neha-ojha
approved these changes
Feb 23, 2021
trociny
reviewed
Feb 23, 2021
There was a problem hiding this comment.
@liewegas ceph osd crush reweight-subtree seems still to have the issue:
adonis:~/ceph/ceph.ci/build% ceph osd crush reweight-subtree adonis 0.5
reweighted subtree id -3 name 'adonis' to 0.5 in crush map
adonis:~/ceph/ceph.ci/build% ceph osd crush dump | jq ".buckets[] | select(.name==\"adonis\") | .items[].weight"
32768
32768
32768
adonis:~/ceph/ceph.ci/build% ceph osd crush dump | jq ".buckets[] | select(.name==\"adonis~ssd\") | .items[].weight"
6461
6461
6461
adonis:~/ceph/ceph.ci/build% ceph osd crush reweight-subtree 'adonis~ssd' 0.5
Invalid command: invalid chars ~ in adonis~ssd
Signed-off-by: Sage Weil <sage@newdream.net>
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
insert_item() already does this, but update_item did not.
Fixes: https://tracker.ceph.com/issues/48065
Signed-off-by: Sage Weil sage@newdream.net