Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cephadm: add docker.service dependency in systemd units #39770

Merged
merged 1 commit into from Mar 3, 2021
Merged

cephadm: add docker.service dependency in systemd units #39770

merged 1 commit into from Mar 3, 2021

Conversation

liewegas
Copy link
Member

@liewegas liewegas commented Mar 1, 2021

This ensures that (1) we start after the docker daemon is running, and
(2) a restart of docker will also restart the ceph services.

Fixes: https://tracker.ceph.com/issues/46745

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@liewegas liewegas requested a review from a team as a code owner March 1, 2021 22:42
@sebastian-philipp
Copy link
Contributor

Would be great to have a unit test for this. Maybe calling get_unit_file?

@liewegas
cephadm: add docker.service dependency in systemd units
0b5bc8f 
This ensures that (1) we start after the docker daemon is running, and
(2) a restart of docker will also restart the ceph services.

Fixes: https://tracker.ceph.com/issues/46745
Signed-off-by: Sage Weil <sage@newdream.net>
@liewegas
Copy link
Member Author

liewegas commented Mar 2, 2021

jenkins test make check

@sebastian-philipp
Copy link
Contributor

https://pulpito.ceph.com/swagner-2021-03-02_17:23:47-rados:cephadm-wip-swagner3-testing-2021-03-02-1313-distro-basic-smithi/

Failures:

@sebastian-philipp sebastian-philipp merged commit d4292af into ceph:master Mar 3, 2021
This was referenced Mar 3, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastian-philipp sebastian-philipp sebastian-philipp approved these changes

Assignees
No one assigned
Labels
cephadm wip-swagner3-testing
Projects
None yet
Milestone
No milestone
2 participants
@liewegas @sebastian-philipp