Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cephadm: split custom container args into argv #39822

Merged
merged 1 commit into from Mar 4, 2021
Merged

cephadm: split custom container args into argv #39822

merged 1 commit into from Mar 4, 2021

Conversation

mgfritch
Copy link
Contributor

@mgfritch mgfritch commented Mar 3, 2021 •
edited

introduced by usage of shlex in 3ea514c

Fixes: https://tracker.ceph.com/issues/49590
Signed-off-by: Michael Fritch mfritch@suse.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@mgfritch mgfritch requested a review from votdev March 3, 2021 20:17
@mgfritch mgfritch requested a review from a team as a code owner March 3, 2021 20:17
@mgfritch
cephadm: split custom container args into argv
1474477 
introduced by usage of `shlex` in 3ea514c

Fixes: https://tracker.ceph.com/issues/49590
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch mgfritch force-pushed the cephadm-custom-container-sample branch from 5759e4e to 1474477 Compare March 3, 2021 20:48
@mgfritch
Copy link
Contributor Author

mgfritch commented Mar 4, 2021

https://pulpito.ceph.com/mgfritch-2021-03-03_23:12:37-rados:cephadm-wip-mgfritch-testing-2021-03-03-1322-distro-basic-smithi/

unrelated e2e failure:
https://pulpito.ceph.com/mgfritch-2021-03-03_23:12:37-rados:cephadm-wip-mgfritch-testing-2021-03-03-1322-distro-basic-smithi/5931707/

@sebastian-philipp sebastian-philipp merged commit aec8aa9 into ceph:master Mar 4, 2021
@mgfritch mgfritch deleted the cephadm-custom-container-sample branch March 4, 2021 16:34
@sebastian-philipp sebastian-philipp mentioned this pull request Mar 8, 2021
Merged
@mgfritch mgfritch mentioned this pull request Apr 20, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastian-philipp sebastian-philipp sebastian-philipp approved these changes

@votdev votdev Awaiting requested review from votdev

Assignees
No one assigned
Labels
cephadm needs-review wip-mgfritch-testing
Projects
None yet
Milestone
No milestone
2 participants
@mgfritch @sebastian-philipp