Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc/cephadm: rewrite "preparation" in adoption.rst #39916

Conversation

zdover23
Copy link
Contributor

@zdover23 zdover23 commented Mar 8, 2021

This rewrites the "Adoption" section of
preparation.rst in the Cephadm manual.

Signed-off-by: Zac Dover zac.dover@gmail.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

Comment on lines 28 to 29
with any release of Ceph that is Octopus (15.2.z) or later, inclusive. For
example, ``docker.io/ceph/ceph:v15.2.0`` will work. The latest stable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably recommend the latest stable release at this point.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to take out the sentence that mentions the specific release. That should help to future-proof this part of the docs.

@zdover23 zdover23 force-pushed the wip-doc-cephadm-adoption-preparation-2021-Mar-08 branch from 66f162a to 34e6371 Compare March 9, 2021 14:34
Copy link
Contributor

@sebastian-philipp sebastian-philipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the title of the commit should start with doc/cephadm:

@zdover23
Copy link
Contributor Author

the title of the commit should start with doc/cephadm:

Ach. So it should.

This rewrites the "Adoption" section of
preparation.rst in the Cephadm manual.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
@zdover23 zdover23 force-pushed the wip-doc-cephadm-adoption-preparation-2021-Mar-08 branch from 34e6371 to 2a47caf Compare March 11, 2021 19:42
@zdover23 zdover23 changed the title doc/dev: rewrite "preparation" in adoption.rst doc/cephadm: rewrite "preparation" in adoption.rst Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants