Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pybind/ceph_argparse: do not print flag name before CephChoices in he… #40111

Merged
merged 1 commit into from Mar 15, 2021

Conversation

tchaikov
Copy link
Contributor

…lp descs

This reverts commit 332abcd.

Signed-off-by: Kefu Chai kchai@redhat.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

…lp descs

This reverts commit 332abcd.

Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov
Copy link
Contributor Author

@adk3798 sorry for reverting your change at #40041

with @sebastian-philipp 's reminder, i realized that

orch ls [<service_type>] [<service_name>] [--export] [plain|json|json-pretty|yaml] [--refresh]

is more correct.

as we use the notation of --export to explain a bool option with true value. and [plain|json|json-pretty|yaml] to explain a positional option.

@tchaikov
Copy link
Contributor Author

jenkins test make check

@tchaikov tchaikov merged commit be47852 into ceph:master Mar 15, 2021
@tchaikov tchaikov deleted the wip-ceph-argparse-no-option-name branch March 15, 2021 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants