nautilus: pybind/mgr/balancer/module.py: assign weight-sets to all buckets before balancing #40128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re balancing Add an additional check to make sure that the choose_args section has the same number of buckets as the crushmap. If not, ensure that get_compat_weight_set_weights assigns weight-sets to all buckets. Without this change, if we end up with an orig_ws, which has fewer buckets than the crushmap, the mgr will crash due a KeyError in do_crush_compat(). Fixes: https://tracker.ceph.com/issues/49576 Signed-off-by: Neha Ojha <nojha@redhat.com> (cherry picked from commit 42c01f0) Conflicts: src/pybind/mgr/balancer/module.py - trivial resolution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/49759
backport of #40007
parent tracker: https://tracker.ceph.com/issues/49576
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh