[DNM: NEEDS REBASE] nautilus: osd: Try other PGs when reservation failures occur #40142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Zafman <dzafman@redhat.com>
This operates like the latest code from Pacific onwards. It is need to make the test of parallelism work because the PG can go into scrubbing then pause like a scrub which takes time to finish would. The old code needlessly did 2 sleeps in a row at the start, first at INACTIVE then immediately again at NEW_CHUNK. Signed-off-by: David Zafman <dzafman@redhat.com>
Fixes: https://tracker.ceph.com/issues/48843 Signed-off-by: David Zafman <dzafman@redhat.com> (cherry picked from commit 08c3ede) Conflicts: PendingReleaseNotes (trivial) src/osd/OSD.cc (trivial) src/osd/PG.cc (set_reserve_failed() in appropriate places) src/osd/PG.h (add reserve_failed to scrubber) src/osd/pg_scrubber.h (not present) src/osd/scrub_machine.cc (not present) src/osd/scrub_machine_lstnr.h (not present) src/osd/scrubber_common.h (not present) Conflicts for Octopus to Nautilus: PendingReleaseNotes (trivial) src/osd/PG.cc (code moved around in Octopus) src/osd/PG.h (trivial)
Signed-off-by: David Zafman <dzafman@redhat.com> (cherry picked from commit dd63577) Increase osd_scrub_sleep time to 7 seconds to make it work in this older release Nautilus: Use regular scrub requests instead of "ceph test #.# scrub"
neha-ojha
requested changes
Mar 17, 2021
There was a problem hiding this comment.
DNM until https://tracker.ceph.com/issues/49868 is resolved
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
|
@dzafman needs rebase. |
smithfarm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox