pacific: librbd: allow interrupted trash move request to be restarted #40254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
March 19, 2021 19:16
The existing list method converts the native TrashImageSpec to the API's rbd_trash_image_info_t which is missing the source field. Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit 21adc92)
Search the trash entries for a matching image name that is still in the moving state and allow the operation to be restarted. Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit ed2d696)
This will help the user self-diagnose that a trash move operation was interrupted and therefore the state is invalid. Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit c808abe)
Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit f6ed98d)
Fixes: https://tracker.ceph.com/issues/49716 Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit 138d71f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/49767
backport of #40010
parent tracker: https://tracker.ceph.com/issues/49716
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh