pacific: common/options: turn off bluestore_fsck_quick_fix_on_mount by default #40309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option enables 3 conversions: 1) pool stats, added in nautilus 2) per-pool omap, added in octopus 3) per-pg omap (replacing (2)) in pacific Upgrading the long running cluster in sepia from octopus to pacific resulted in conversion (3). This conversion isn't particularly useful yet since the follow-on optimization of pg removal aren't in pacific yet. This took 25 minutes for the SSD-based osds with <10GB of omap. That's a lot of disruption, and some clusters have 10x that much omap data. Upgrades going from nautilus to pacific will miss the finer-grained stats granularity, but isn't such an important feature it's worth causing potential availability problems. In the future we can orchestrate these format changes via cephadm/rook to minimize the impact on the whole cluster, e.g. going an osd at a time or doing it during an off-peak period, and not necessarily at the same time as an upgrade. Fixes: https://tracker.ceph.com/issues/45265 Signed-off-by: Josh Durgin <jdurgin@redhat.com> (cherry picked from commit c3e7acb)
jdurgin
approved these changes
Mar 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/49920
backport of #40198
parent tracker: https://tracker.ceph.com/issues/45265
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh