New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mgr/dashboard: Host Maintenance Follow ups #40426
Merged
epuertat
merged 1 commit into
ceph:master
from
rhcs-dashboard:host-maintenance-followups
Apr 27, 2021
Merged
mgr/dashboard: Host Maintenance Follow ups #40426
epuertat
merged 1 commit into
ceph:master
from
rhcs-dashboard:host-maintenance-followups
Apr 27, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nizamial09
force-pushed
the
host-maintenance-followups
branch
from
March 26, 2021 14:27
d7ec515
to
ab16012
Compare
jmolmo
requested changes
Mar 31, 2021
jmolmo
requested changes
Mar 31, 2021
nizamial09
force-pushed
the
host-maintenance-followups
branch
from
April 5, 2021 06:04
ab16012
to
c5d9db4
Compare
nizamial09
changed the title
[WIP]mgr/dashboard: Host Maintenance Follow ups
mgr/dashboard: Host Maintenance Follow ups
Apr 5, 2021
nizamial09
requested review from
callithea,
aaSharma14,
alfonsomthd,
avanthakkar and
epuertat
and removed request for
a team
April 5, 2021 06:11
jenkins test api |
jenkins test docs |
jenkins test make check |
jenkins test api |
avanthakkar
requested changes
Apr 5, 2021
nizamial09
force-pushed
the
host-maintenance-followups
branch
from
April 6, 2021 06:22
c5d9db4
to
222e4f5
Compare
nizamial09
force-pushed
the
host-maintenance-followups
branch
from
April 6, 2021 07:38
222e4f5
to
e0b85f3
Compare
avanthakkar
approved these changes
Apr 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
nizamial09
force-pushed
the
host-maintenance-followups
branch
from
April 14, 2021 05:42
e0b85f3
to
1c013e6
Compare
nizamial09
force-pushed
the
host-maintenance-followups
branch
from
April 26, 2021 07:48
1c013e6
to
6265da7
Compare
alfonsomthd
approved these changes
Apr 26, 2021
epuertat
approved these changes
Apr 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @nizamial09 !
jmolmo
approved these changes
Apr 26, 2021
Added the ability to create a host in maintenance mode Fixes: https://tracker.ceph.com/issues/49998 Signed-off-by: Nizamudeen A <nia@redhat.com>
nizamial09
force-pushed
the
host-maintenance-followups
branch
from
April 27, 2021 10:42
6265da7
to
23bdf20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to create a host in maintenance mode
Included tests and improvements to the previous codes.
Fixes: https://tracker.ceph.com/issues/49998
Signed-off-by: Nizamudeen A nia@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox