Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/dashboard: Host Maintenance Follow ups #40426

Merged
merged 1 commit into from Apr 27, 2021

Conversation

nizamial09
Copy link
Member

@nizamial09 nizamial09 commented Mar 26, 2021

Added the ability to create a host in maintenance mode

Included tests and improvements to the previous codes.

maintenance_create

Fixes: https://tracker.ceph.com/issues/49998
Signed-off-by: Nizamudeen A nia@redhat.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

src/pybind/mgr/cephadm/inventory.py Outdated Show resolved Hide resolved
Dashboard automation moved this from In progress to Review in progress Mar 31, 2021
@github-actions github-actions bot added the tests label Apr 5, 2021
@nizamial09 nizamial09 requested a review from jmolmo April 5, 2021 06:10
@nizamial09 nizamial09 changed the title [WIP]mgr/dashboard: Host Maintenance Follow ups mgr/dashboard: Host Maintenance Follow ups Apr 5, 2021
@nizamial09 nizamial09 marked this pull request as ready for review April 5, 2021 06:11
@nizamial09 nizamial09 requested a review from a team April 5, 2021 06:11
@nizamial09 nizamial09 requested review from a team as code owners April 5, 2021 06:11
@nizamial09 nizamial09 requested review from callithea, aaSharma14, alfonsomthd, avanthakkar and epuertat and removed request for a team April 5, 2021 06:11
@nizamial09 nizamial09 removed the cephadm label Apr 5, 2021
@nizamial09
Copy link
Member Author

jenkins test api

@nizamial09
Copy link
Member Author

jenkins test docs

@nizamial09
Copy link
Member Author

jenkins test make check

@nizamial09
Copy link
Member Author

jenkins test api

Copy link
Contributor

@avanthakkar avanthakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@epuertat epuertat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @nizamial09 !

@epuertat epuertat moved this from Review in progress to Ready-to-merge in Dashboard Apr 26, 2021
Dashboard automation moved this from Ready-to-merge to Reviewer approved Apr 26, 2021
@nizamial09 nizamial09 moved this from Reviewer approved to Ready-to-merge in Dashboard Apr 26, 2021
Added the ability to create a host in maintenance mode

Fixes: https://tracker.ceph.com/issues/49998
Signed-off-by: Nizamudeen A <nia@redhat.com>
@epuertat epuertat merged commit 95c52c9 into ceph:master Apr 27, 2021
Dashboard automation moved this from Ready-to-merge to Done Apr 27, 2021
@epuertat epuertat deleted the host-maintenance-followups branch April 27, 2021 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Dashboard
  
Done
5 participants