Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgr/cephadm: don't cleanup the daemon keyring on failed redeploy #40459

Merged
merged 1 commit into from Apr 5, 2021
Merged

mgr/cephadm: don't cleanup the daemon keyring on failed redeploy #40459

merged 1 commit into from Apr 5, 2021

Conversation

melissa-kun-li
Copy link
Contributor

@melissa-kun-li melissa-kun-li commented Mar 29, 2021 •
edited

Fixes: https://tracker.ceph.com/issues/49872
Signed-off-by: Melissa Li li.melissa.kun@gmail.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@melissa-kun-li melissa-kun-li requested a review from a team as a code owner March 29, 2021 04:49
@melissa-kun-li
Copy link
Contributor Author

make check failed:

unittest-seastore: ../src/crimson/os/seastore/onode_manager/staged-fltree/node_delta_recorder.h:21: virtual crimson::os::seastore::onode::DeltaRecorder::~DeltaRecorder(): Assertion `is_empty()' failed.
Aborting on shard 0.

I think it's related to: https://tracker.ceph.com/issues/50028 ?

@adk3798
Copy link
Contributor

adk3798 commented Mar 29, 2021 •
edited

make check failed:

unittest-seastore: ../src/crimson/os/seastore/onode_manager/staged-fltree/node_delta_recorder.h:21: virtual crimson::os::seastore::onode::DeltaRecorder::~DeltaRecorder(): Assertion `is_empty()' failed.
Aborting on shard 0.

I think it's related to: https://tracker.ceph.com/issues/50028 ?

Yeah, that failure definitely looks unrelated to the changes in this pull request. There a few tests that will occasionally fail in make check (rbd unit tests for example) and sometimes make check will fail due to things unrelated to ceph (such as possibly failing to install some dependency). If you're confident, as you would be in this case, the failure is unrelated to your changes and other ceph pull requests opened around the same time have make check passing, you can just tell Jenkins to rerun the make check by commenting "jenkins test make check" on the pull request. We do it fairly often. As long as the make check isn't just repeatedly failing it isn't an issue.

@adk3798
Copy link
Contributor

adk3798 commented Mar 29, 2021

jenkins test make check

adk3798
adk3798 approved these changes Mar 29, 2021
View reviewed changes
Copy link
Contributor

@adk3798 adk3798 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@melissa-kun-li
Copy link
Contributor Author

Thanks for letting me know @adk3798 !

@melissa-kun-li
Copy link
Contributor Author

jenkins test make check

1 similar comment
@tchaikov
Copy link
Contributor

tchaikov commented Apr 1, 2021

jenkins test make check

@liewegas liewegas merged commit 6200ba4 into ceph:master Apr 5, 2021
@liewegas liewegas mentioned this pull request Apr 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastian-philipp sebastian-philipp sebastian-philipp left review comments

@adk3798 adk3798 adk3798 approved these changes

Assignees
No one assigned
Labels
cephadm pybind wip-sage-testing
Projects
None yet
Milestone
No milestone
5 participants
@melissa-kun-li @adk3798 @tchaikov @sebastian-philipp @liewegas