nautilus: test/pybind: s/nosetests/python3/ #40536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
different distros package python3-nose in different ways by adding different postfix to "/usr/bin/nosetests" to differentiate it from its python2 counterpart. * on bionic, python3-nose offers "nosetests3" * on el8, python3-nose offers "nosetests-3" and "nosetests-3.6" Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit 717aaad)
3 tasks
tchaikov
force-pushed
the
nautilus-nose-py3
branch
from
7c351f5
to
ccbda45
Compare
badone
approved these changes
Apr 1, 2021
|
jenkins test make check |
badone
approved these changes
Apr 1, 2021
tchaikov
force-pushed
the
nautilus-nose-py3
branch
from
aef4a3d
to
15071f3
Compare
|
jenkins test api |
|
jenkins test make check |
tchaikov
force-pushed
the
nautilus-nose-py3
branch
from
15071f3
to
db54943
Compare
|
jenkins test make check |
tchaikov
force-pushed
the
nautilus-nose-py3
branch
from
db54943
to
1926509
Compare
badone
approved these changes
Apr 1, 2021
this addresses a regression introduced by 2cd9429. which from ..tools import ensure_str and it causes recursive import. so, in this change, an copy of ensure_str() is added to access_control.py this change is not cherry-picked from master, as the offending commit which is fixed by this change is not included in master. Signed-off-by: Kefu Chai <kchai@redhat.com>
this change is not cherry-picked from master, as we don't have following
warnings in master, like:
************* Module dashboard.controllers.saml2
intern-builtin,
controllers/saml2.py:57:8: R1720: Unnecessary "else" after "raise" (no-else-raise)
also bump up the versions of pylint and astroid, so they
can work with python3.8.
see
pylint-dev/astroid@28fc86f
Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
force-pushed
the
nautilus-nose-py3
branch
2 times, most recently
from
ef15fc4
to
c8f0b79
Compare
|
alfonsomthd
approved these changes
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we still support python2 in nautilus. but we need to run "make check" in python3. hence the change.
this change should address the test failure like
see https://jenkins.ceph.com/job/ceph-pull-requests/72581/console
different distros package python3-nose in different ways by adding
different postfix to "/usr/bin/nosetests" to differentiate it from
its python2 counterpart.
Signed-off-by: Kefu Chai kchai@redhat.com
(cherry picked from commit 717aaad)
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox